From: bnilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, john.c.harrison@intel.com
Subject: [[CI] 01/12] drm/xe/guc: Remove spurious line feed in debug print
Date: Fri, 20 Sep 2024 19:36:35 +0530 [thread overview]
Message-ID: <20240920140646.618008-2-badal.nilawar@intel.com> (raw)
In-Reply-To: <20240920140646.618008-1-badal.nilawar@intel.com>
From: John Harrison <John.C.Harrison@Intel.com>
Including line feeds at the start of a debug print messes up the
output when sent to dmesg. The break appears between all the useful
prefix information and the actual string being printed. In this case,
each block of data has a very clear start line and an extra delimeter
is really not necessary. So don't do it.
v2: Fix typo in commit message (review feedback from Michal W.)
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
---
drivers/gpu/drm/xe/xe_guc_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 4b95f75b1546..a63fe0a9077a 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -1523,7 +1523,7 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot,
drm_puts(p, "H2G CTB (all sizes in DW):\n");
guc_ctb_snapshot_print(&snapshot->h2g, p);
- drm_puts(p, "\nG2H CTB (all sizes in DW):\n");
+ drm_puts(p, "G2H CTB (all sizes in DW):\n");
guc_ctb_snapshot_print(&snapshot->g2h, p);
drm_printf(p, "\tg2h outstanding: %d\n",
--
2.34.1
next prev parent reply other threads:[~2024-09-20 13:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 14:06 [[CI] 00/12] Debug g2h timeout issue bnilawar
2024-09-20 14:06 ` bnilawar [this message]
2024-09-20 14:06 ` [[CI] 02/12] drm/xe/devcoredump: Use drm_puts and already cached local variables bnilawar
2024-09-20 14:06 ` [[CI] 03/12] drm/xe/devcoredump: Improve section headings and add tile info bnilawar
2024-09-20 14:06 ` [[CI] 04/12] drm/xe/devcoredump: Add ASCII85 dump helper function bnilawar
2024-09-20 14:06 ` [[CI] 05/12] drm/xe/guc: Copy GuC log prior to dumping bnilawar
2024-09-20 14:06 ` [[CI] 06/12] drm/xe/guc: Use a two stage dump for GuC logs and add more info bnilawar
2024-09-20 14:06 ` [[CI] 07/12] drm/print: Introduce drm_line_printer bnilawar
2024-09-20 14:06 ` [[CI] 08/12] drm/xe/guc: Dead CT helper bnilawar
2024-09-20 14:06 ` [[CI] 09/12] drm/xe/guc: Dump entire CTB on errors bnilawar
2024-09-20 14:06 ` [[CI] 10/12] drm/xe/guc: Add GuC log to devcoredump captures bnilawar
2024-09-20 14:06 ` [[CI] 11/12] drm/xe/guc: Add a helper function for dumping GuC log to dmesg bnilawar
2024-09-20 14:06 ` [[CI] 12/12] [For CI] Debug prints/logs to debug G2H timeout issue bnilawar
2024-09-20 14:43 ` ✓ CI.Patch_applied: success for 10/12] drm/xe/guc: Add GuC log to devcoredump captures Patchwork
2024-09-20 14:43 ` ✓ CI.checkpatch: " Patchwork
2024-09-20 14:44 ` ✓ CI.KUnit: " Patchwork
2024-09-20 14:56 ` ✓ CI.Build: " Patchwork
2024-09-20 14:58 ` ✓ CI.Hooks: " Patchwork
2024-09-20 15:00 ` ✓ CI.checksparse: " Patchwork
2024-09-20 15:18 ` ✓ CI.BAT: " Patchwork
2024-09-20 20:37 ` ✗ CI.FULL: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-20 14:29 [CI 00/12] Debug g2h timeout issue Badal Nilawar
2024-09-20 14:29 ` [CI 01/12] drm/xe/guc: Remove spurious line feed in debug print Badal Nilawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920140646.618008-2-badal.nilawar@intel.com \
--to=badal.nilawar@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox