From: Matt Roper <matthew.d.roper@intel.com>
To: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>,
Tejas Upadhyay <tejas.upadhyay@intel.com>
Subject: Re: [PATCH v2 1/4] drm/xe/mcr: Use Xe2_LPM steering tables for Xe2_HPM
Date: Fri, 20 Sep 2024 12:18:27 -0700 [thread overview]
Message-ID: <20240920191818.GV5091@mdroper-desk1.amr.corp.intel.com> (raw)
In-Reply-To: <20240920171223.64969-2-gustavo.sousa@intel.com>
On Fri, Sep 20, 2024 at 02:12:08PM -0300, Gustavo Sousa wrote:
> According to Bspec, Xe2 steering tables must be used for Xe2_HPM, just
> as it is with Xe2_LPM. Update our driver to reflect that.
>
> Bspec: 71186
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_mcr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c
> index 2671ce6b1a76..4c0767403881 100644
> --- a/drivers/gpu/drm/xe/xe_gt_mcr.c
> +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c
> @@ -441,7 +441,7 @@ void xe_gt_mcr_init(struct xe_gt *gt)
> if (gt->info.type == XE_GT_TYPE_MEDIA) {
> drm_WARN_ON(&xe->drm, MEDIA_VER(xe) < 13);
>
> - if (MEDIA_VER(xe) >= 20) {
> + if (MEDIA_VERx100(xe) >= 1301) {
> gt->steering[OADDRM].ranges = xe2lpm_gpmxmt_steering_table;
> gt->steering[INSTANCE0].ranges = xe2lpm_instance0_steering_table;
> } else {
> --
> 2.46.1
>
--
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
next prev parent reply other threads:[~2024-09-20 19:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 17:12 [PATCH v2 0/4] Xe2 performance tuning updates Gustavo Sousa
2024-09-20 17:12 ` [PATCH v2 1/4] drm/xe/mcr: Use Xe2_LPM steering tables for Xe2_HPM Gustavo Sousa
2024-09-20 19:18 ` Matt Roper [this message]
2024-09-20 17:12 ` [PATCH v2 2/4] drm/xe/xe2: Extend performance tuning to media GT Gustavo Sousa
2024-09-20 17:12 ` [PATCH v2 3/4] drm/xe/xe2: Assume tuning settings also apply for future " Gustavo Sousa
2024-09-20 17:12 ` [PATCH v2 4/4] drm/xe/xe2: Add performance tuning for L3 cache flushing Gustavo Sousa
2024-09-20 19:26 ` Matt Roper
2024-09-20 20:06 ` Gustavo Sousa
2024-09-20 20:28 ` Matt Roper
2024-09-20 17:18 ` ✓ CI.Patch_applied: success for Xe2 performance tuning updates (rev2) Patchwork
2024-09-20 17:18 ` ✓ CI.checkpatch: " Patchwork
2024-09-20 17:19 ` ✓ CI.KUnit: " Patchwork
2024-09-20 17:31 ` ✓ CI.Build: " Patchwork
2024-09-20 17:33 ` ✓ CI.Hooks: " Patchwork
2024-09-20 17:34 ` ✓ CI.checksparse: " Patchwork
2024-09-20 17:53 ` ✓ CI.BAT: " Patchwork
2024-09-20 22:15 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920191818.GV5091@mdroper-desk1.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=gustavo.sousa@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=sai.teja.pottumuttu@intel.com \
--cc=tejas.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox