Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Make wedged_mode debugfs writable
@ 2024-10-02 23:06 Matt Roper
  2024-10-02 23:12 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Matt Roper @ 2024-10-02 23:06 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper, Rodrigo Vivi

The intent of this debugfs entry is to allow modification of wedging
behavior, either from IGT tests or during manual debug; it should be
marked as writable to properly reflect this.  In practice this hasn't
caused a problem because we always access wedged_mode as root, which
ignores file permissions, but it's still misleading to have the entry
incorrectly marked as RO.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Fixes: 6b8ef44cc0a9 ("drm/xe: Introduce the wedged_mode debugfs")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugfs.c
index 668615c6b172..fe4319eb13fd 100644
--- a/drivers/gpu/drm/xe/xe_debugfs.c
+++ b/drivers/gpu/drm/xe/xe_debugfs.c
@@ -187,7 +187,7 @@ void xe_debugfs_register(struct xe_device *xe)
 	debugfs_create_file("forcewake_all", 0400, root, xe,
 			    &forcewake_all_fops);
 
-	debugfs_create_file("wedged_mode", 0400, root, xe,
+	debugfs_create_file("wedged_mode", 0600, root, xe,
 			    &wedged_mode_fops);
 
 	for (mem_type = XE_PL_VRAM0; mem_type <= XE_PL_VRAM1; ++mem_type) {
-- 
2.46.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-10-03 20:28 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-02 23:06 [PATCH] drm/xe: Make wedged_mode debugfs writable Matt Roper
2024-10-02 23:12 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-02 23:13 ` ✓ CI.checkpatch: " Patchwork
2024-10-02 23:14 ` ✓ CI.KUnit: " Patchwork
2024-10-02 23:25 ` ✓ CI.Build: " Patchwork
2024-10-02 23:28 ` ✓ CI.Hooks: " Patchwork
2024-10-02 23:29 ` ✓ CI.checksparse: " Patchwork
2024-10-02 23:47 ` ✓ CI.BAT: " Patchwork
2024-10-03  0:58 ` ✗ CI.FULL: failure " Patchwork
2024-10-03 20:27 ` [PATCH] " Gustavo Sousa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox