From: Nirmoy Das <nirmoy.das@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Nirmoy Das <nirmoy.das@intel.com>,
stable@vger.kernel.org,
Bommu Krishnaiah <krishnaiah.bommu@intel.com>,
Matthew Auld <matthew.auld@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken
Date: Fri, 11 Oct 2024 17:10:29 +0200 [thread overview]
Message-ID: <20241011151029.4160630-1-nirmoy.das@intel.com> (raw)
do_comapre() can return success after a timedout wait_woken() which was
treated as -ETIME. The loop calling wait_woken() sets correct err so
there is no need to re-evaluate err.
v2: Remove entire check that reevaluate err at the end(Matt)
Fixes: e670f0b4ef24 ("drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl")
Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
Cc: <stable@vger.kernel.org> # v6.8+
Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/xe/xe_wait_user_fence.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
index d46fa8374980..f5deb81eba01 100644
--- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
+++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
@@ -169,9 +169,6 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
args->timeout = 0;
}
- if (!timeout && !(err < 0))
- err = -ETIME;
-
if (q)
xe_exec_queue_put(q);
--
2.46.0
next reply other threads:[~2024-10-11 15:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 15:10 Nirmoy Das [this message]
2024-10-11 19:54 ` ✓ CI.Patch_applied: success for drm/xe/ufence: ufence can be signaled right after wait_woken (rev2) Patchwork
2024-10-11 19:54 ` ✓ CI.checkpatch: " Patchwork
2024-10-11 19:56 ` ✓ CI.KUnit: " Patchwork
2024-10-11 20:11 ` ✓ CI.Build: " Patchwork
2024-10-11 20:13 ` ✓ CI.Hooks: " Patchwork
2024-10-11 20:15 ` ✓ CI.checksparse: " Patchwork
2024-10-12 2:07 ` [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken Matthew Brost
2024-10-12 2:35 ` ✗ CI.FULL: failure for drm/xe/ufence: ufence can be signaled right after wait_woken (rev2) Patchwork
2024-10-14 8:06 ` Nirmoy Das
2024-10-14 7:53 ` [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken Matthew Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011151029.4160630-1-nirmoy.das@intel.com \
--to=nirmoy.das@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=krishnaiah.bommu@intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox