Re: [PATCH v2] drm/xe/ufence: ufence can be signaled right after wait_woken

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Oct 11, 2024 at 05:10:29PM +0200, Nirmoy Das wrote:
> do_comapre() can return success after a timedout wait_woken() which was
> treated as -ETIME. The loop calling wait_woken() sets correct err so
> there is no need to re-evaluate err.
> 
> v2: Remove entire check that reevaluate err at the end(Matt)
> 
> Fixes: e670f0b4ef24 ("drm/xe/uapi: Return correct error code for xe_wait_user_fence_ioctl")
> Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1630
> Cc: <stable@vger.kernel.org> # v6.8+
> Cc: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_wait_user_fence.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> index d46fa8374980..f5deb81eba01 100644
> --- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
> +++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
> @@ -169,9 +169,6 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
>  			args->timeout = 0;
>  	}
>  
> -	if (!timeout && !(err < 0))
> -		err = -ETIME;
> -
>  	if (q)
>  		xe_exec_queue_put(q);
>  
> -- 
> 2.46.0
>