Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/migrate: Fix inappropriate error printing in xe_migrate_sanity_test()
@ 2024-10-25  9:13 Wang Hai
  2024-10-28 18:33 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Wang Hai @ 2024-10-25  9:13 UTC (permalink / raw)
  To: lucas.demarchi, thomas.hellstrom, rodrigo.vivi, maarten.lankhorst,
	mripard, tzimmermann, airlied, simona, matthew.auld,
	matthew.brost, michal.wajdeczko, akshata.jahagirdar,
	david.kershner, matthew.d.roper, zhangxiaoxu5
  Cc: intel-xe, dri-devel, linux-kernel, wanghai38

When creating pin map for tiny fails, the PTR_ERR(pt) is printed instead
of PTR_ERR(tiny), which makes it impossible to accurately get the true
cause of the error.

Print PTR_ERR(tiny) after creating pin map for tiny fails.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
 drivers/gpu/drm/xe/tests/xe_migrate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_migrate.c b/drivers/gpu/drm/xe/tests/xe_migrate.c
index 1a192a2a941b..4542925445de 100644
--- a/drivers/gpu/drm/xe/tests/xe_migrate.c
+++ b/drivers/gpu/drm/xe/tests/xe_migrate.c
@@ -224,8 +224,8 @@ static void xe_migrate_sanity_test(struct xe_migrate *m, struct kunit *test)
 				    XE_BO_FLAG_VRAM_IF_DGFX(tile) |
 				    XE_BO_FLAG_PINNED);
 	if (IS_ERR(tiny)) {
-		KUNIT_FAIL(test, "Failed to allocate fake pt: %li\n",
-			   PTR_ERR(pt));
+		KUNIT_FAIL(test, "Failed to allocate fake tiny: %li\n",
+			   PTR_ERR(tiny));
 		goto free_pt;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-10-29 12:02 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-25  9:13 [PATCH] drm/xe/migrate: Fix inappropriate error printing in xe_migrate_sanity_test() Wang Hai
2024-10-28 18:33 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-28 18:34 ` ✓ CI.checkpatch: " Patchwork
2024-10-28 18:35 ` ✓ CI.KUnit: " Patchwork
2024-10-28 18:46 ` ✓ CI.Build: " Patchwork
2024-10-28 18:49 ` ✓ CI.Hooks: " Patchwork
2024-10-28 18:50 ` ✓ CI.checksparse: " Patchwork
2024-10-28 19:14 ` ✓ CI.BAT: " Patchwork
2024-10-28 20:07 ` ✗ CI.FULL: failure " Patchwork
2024-10-29 12:02 ` Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox