Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro
@ 2024-10-27  4:57 Gyeyoung Baek
  2024-10-28 19:19 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (12 more replies)
  0 siblings, 13 replies; 15+ messages in thread
From: Gyeyoung Baek @ 2024-10-27  4:57 UTC (permalink / raw)
  To: Lucas De Marchi, Oded Gabbay, Thomas Hellström,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
	Daniel Vetter
  Cc: Gyeyoung Baek, intel-xe, dri-devel, linux-kernel

In the previous code, there is build error.
if CONFIG_DRM_USE_DYNAMIC_DEBUG is set,
'drm_dbg' function is replaced with '__dynamic_func_call_cls',
which is replaced with a do while statement.

The problem is that,
XE_IOCTL_DBG uses this function for conditional expression.

so I fix the expression to be compatible with the do while statement,
by referring to "https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html".

Signed-off-by: Gyeyoung Baek <gye976@gmail.com>
---
 drivers/gpu/drm/xe/xe_macros.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_macros.h b/drivers/gpu/drm/xe/xe_macros.h
index daf56c846d03..58a9d1e33502 100644
--- a/drivers/gpu/drm/xe/xe_macros.h
+++ b/drivers/gpu/drm/xe/xe_macros.h
@@ -11,8 +11,8 @@
 #define XE_WARN_ON WARN_ON
 
 #define XE_IOCTL_DBG(xe, cond) \
-	((cond) && (drm_dbg(&(xe)->drm, \
-			    "Ioctl argument check failed at %s:%d: %s", \
-			    __FILE__, __LINE__, #cond), 1))
+	({drm_dbg(&(xe)->drm, \
+		"Ioctl argument check failed at %s:%d: %s", \
+		__FILE__, __LINE__, #cond); (cond); })
 
 #endif
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2024-11-01 10:06 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-27  4:57 [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro Gyeyoung Baek
2024-10-28 19:19 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-28 19:20 ` ✓ CI.checkpatch: " Patchwork
2024-10-28 19:21 ` ✓ CI.KUnit: " Patchwork
2024-10-28 19:32 ` ✓ CI.Build: " Patchwork
2024-10-28 19:35 ` ✓ CI.Hooks: " Patchwork
2024-10-28 19:36 ` ✓ CI.checksparse: " Patchwork
2024-10-28 19:47 ` [PATCH] " Lucas De Marchi
2024-10-29  6:17   ` gyeyoung
2024-10-29  6:19 ` ✓ CI.Patch_applied: success for drm/xe: Fix build error for XE_IOCTL_DBG macro (rev2) Patchwork
2024-10-29  6:19 ` ✓ CI.checkpatch: " Patchwork
2024-10-29  6:20 ` ✓ CI.KUnit: " Patchwork
2024-10-29  6:32 ` ✓ CI.Build: " Patchwork
2024-10-29  6:34 ` ✓ CI.Hooks: " Patchwork
2024-10-29  6:35 ` ✓ CI.checksparse: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox