From: Tomasz Lis <tomasz.lis@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
"Michał Wajdeczko" <michal.wajdeczko@intel.com>
Subject: [PATCH v1 1/1] drm/xe/guc: Do not assert CTB state while sending MMIO
Date: Thu, 7 Nov 2024 16:13:57 +0100 [thread overview]
Message-ID: <20241107151357.1623733-2-tomasz.lis@intel.com> (raw)
In-Reply-To: <20241107151357.1623733-1-tomasz.lis@intel.com>
During VF post-migration recovery, MMIO communication channel to GuC
is used, despite CTB channel being enabled. This behavior is rooted
in the save-restore architecture specification.
Therefore, a VF driver cannot assert that CTB is disabled while sending
MMIO messages to GuC. Such assertion needs to be PF only, or be removed.
This patch simply removes the assertion.
Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
Suggested-by: Michał Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/xe/xe_guc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 7224593c9ce9..df1ba94cf4ca 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -945,7 +945,6 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
BUILD_BUG_ON(VF_SW_FLAG_COUNT != MED_VF_SW_FLAG_COUNT);
- xe_assert(xe, !xe_guc_ct_enabled(&guc->ct));
xe_assert(xe, len);
xe_assert(xe, len <= VF_SW_FLAG_COUNT);
xe_assert(xe, len <= MED_VF_SW_FLAG_COUNT);
--
2.25.1
next prev parent reply other threads:[~2024-11-07 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 15:13 [PATCH v1 0/1] drm/xe/vf: Post-migration recovery, remove MMIO assert Tomasz Lis
2024-11-07 15:13 ` Tomasz Lis [this message]
2024-11-07 16:56 ` [PATCH v1 1/1] drm/xe/guc: Do not assert CTB state while sending MMIO Michal Wajdeczko
2024-11-08 3:04 ` Matthew Brost
2024-11-09 14:19 ` Michal Wajdeczko
2024-11-07 15:20 ` ✓ CI.Patch_applied: success for drm/xe/vf: Post-migration recovery, remove MMIO assert Patchwork
2024-11-07 15:20 ` ✓ CI.checkpatch: " Patchwork
2024-11-07 15:22 ` ✓ CI.KUnit: " Patchwork
2024-11-07 15:41 ` ✓ CI.Build: " Patchwork
2024-11-07 15:43 ` ✓ CI.Hooks: " Patchwork
2024-11-07 15:44 ` ✓ CI.checksparse: " Patchwork
2024-11-07 16:25 ` ✓ CI.BAT: " Patchwork
2024-11-08 22:16 ` ✗ CI.FULL: failure " Patchwork
2024-11-09 14:05 ` Michal Wajdeczko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241107151357.1623733-2-tomasz.lis@intel.com \
--to=tomasz.lis@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox