From: Matthew Brost <matthew.brost@intel.com>
To: intel-xe@lists.freedesktop.org
Subject: [PATCH v3 4/7] drm/xe: Improve schedule disable response failure
Date: Tue, 12 Nov 2024 14:01:24 -0800 [thread overview]
Message-ID: <20241112220127.1369527-5-matthew.brost@intel.com> (raw)
In-Reply-To: <20241112220127.1369527-1-matthew.brost@intel.com>
Print Guc ID and take devcoredump on schedule disable response failure.
GuC ID is useful information and a schedule disable response failure is
possible the LRC state is corrupted so a devcoredump is helpful to debug.
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 663ad4d97b34..3d61c650c0d2 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1124,7 +1124,10 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
if (!ret || xe_guc_read_stopped(guc)) {
trigger_reset:
if (!ret)
- xe_gt_warn(guc_to_gt(guc), "Schedule disable failed to respond");
+ xe_gt_warn(guc_to_gt(guc),
+ "Schedule disable failed to respond, guc_id=%d",
+ q->guc->id);
+ xe_devcoredump(q, job);
set_exec_queue_extra_ref(q);
xe_exec_queue_get(q); /* GT reset owns this */
set_exec_queue_banned(q);
--
2.34.1
next prev parent reply other threads:[~2024-11-12 22:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 22:01 [PATCH v3 0/7] Devcoredump Improvements Matthew Brost
2024-11-12 22:01 ` [PATCH v3 1/7] drm/xe: Add xe_ring_lrc_is_idle() helper Matthew Brost
2024-11-12 22:01 ` [PATCH v3 2/7] drm/xe: Add ring address to LRC snapshot Matthew Brost
2024-11-12 22:01 ` [PATCH v3 3/7] drm/xe: Add ring start " Matthew Brost
2024-11-12 22:01 ` Matthew Brost [this message]
2024-11-14 1:48 ` [PATCH v3 4/7] drm/xe: Improve schedule disable response failure John Harrison
2024-11-12 22:01 ` [PATCH v3 5/7] drm/xe: Add exec queue param to devcoredump Matthew Brost
2024-11-12 22:01 ` [PATCH v3 6/7] drm/xe: Change xe_engine_snapshot_capture_for_job to be for queue Matthew Brost
2024-11-12 22:01 ` [PATCH v3 7/7] drm/xe: Wire devcoredump to LR TDR Matthew Brost
2024-11-14 2:01 ` John Harrison
2024-11-13 14:25 ` ✓ CI.Patch_applied: success for Devcoredump Improvements (rev4) Patchwork
2024-11-13 14:25 ` ✓ CI.checkpatch: " Patchwork
2024-11-13 14:27 ` ✓ CI.KUnit: " Patchwork
2024-11-13 14:31 ` ✗ CI.Build: failure " Patchwork
2024-11-13 18:16 ` ✓ CI.Patch_applied: success for Devcoredump Improvements (rev5) Patchwork
2024-11-13 18:17 ` ✓ CI.checkpatch: " Patchwork
2024-11-13 18:18 ` ✓ CI.KUnit: " Patchwork
2024-11-13 18:22 ` ✗ CI.Build: failure " Patchwork
2024-11-14 0:47 ` ✓ CI.Patch_applied: success for Devcoredump Improvements (rev6) Patchwork
2024-11-14 0:48 ` ✓ CI.checkpatch: " Patchwork
2024-11-14 0:49 ` ✓ CI.KUnit: " Patchwork
2024-11-14 0:54 ` ✗ CI.Build: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112220127.1369527-5-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox