Re: [PATCH v3 4/7] drm/xe: Improve schedule disable response failure

[John Harrison <john.c.harrison@intel.com>]

On 11/12/2024 14:01, Matthew Brost wrote:
> Print Guc ID and take devcoredump on schedule disable response failure.
> GuC ID is useful information and a schedule disable response failure is
> possible the LRC state is corrupted so a devcoredump is helpful to debug.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_submit.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 663ad4d97b34..3d61c650c0d2 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1124,7 +1124,10 @@ guc_exec_queue_timedout_job(struct drm_sched_job *drm_job)
>   		if (!ret || xe_guc_read_stopped(guc)) {
>   trigger_reset:
>   			if (!ret)
> -				xe_gt_warn(guc_to_gt(guc), "Schedule disable failed to respond");
> +				xe_gt_warn(guc_to_gt(guc),
> +					   "Schedule disable failed to respond, guc_id=%d",
> +					   q->guc->id);
> +			xe_devcoredump(q, job);
This is premature. The extra parameter is not added until patch #5!

John.

>   			set_exec_queue_extra_ref(q);
>   			xe_exec_queue_get(q);	/* GT reset owns this */
>   			set_exec_queue_banned(q);