From: Nemesa Garg <nemesa.garg@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Nemesa Garg <nemesa.garg@intel.com>
Subject: [PATCH v5 4/6] drm/i915/display: Call panel_fitting from pipe_config
Date: Wed, 20 Nov 2024 11:08:36 +0530 [thread overview]
Message-ID: <20241120053838.3794419-5-nemesa.garg@intel.com> (raw)
In-Reply-To: <20241120053838.3794419-1-nemesa.garg@intel.com>
In panel fitter/pipe scaler scenario the pch_pfit configuration
currently takes place before accounting for pipe_src width for
joiner. This causes issue when pch_pfit and joiner get enabled
together. Call panel_fitting from pipe_config once pipe src is
computed.
-v5: Add GMCH check [Ville]
Signed-off-by: Nemesa Garg <nemesa.garg@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 22 ++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 6ad47cf0d419..c58897cddde1 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -104,6 +104,7 @@
#include "intel_pch_display.h"
#include "intel_pch_refclk.h"
#include "intel_pcode.h"
+#include "intel_pfit.h"
#include "intel_pipe_crc.h"
#include "intel_plane_initial.h"
#include "intel_pmdemand.h"
@@ -2563,6 +2564,25 @@ static int intel_crtc_compute_pipe_src(struct intel_crtc_state *crtc_state)
return 0;
}
+static void intel_crtc_compute_pfit(struct intel_atomic_state *state,
+ struct intel_crtc_state *crtc_state)
+{
+ struct intel_display *display = to_intel_display(crtc_state);
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct drm_connector *connector;
+ struct drm_connector_state *connector_state;
+ int i;
+
+ for_each_new_connector_in_state(&state->base, connector,
+ connector_state, i) {
+ if (connector_state->crtc != &crtc->base)
+ continue;
+
+ if (!HAS_GMCH(display))
+ intel_pch_panel_fitting(crtc_state, connector_state);
+ }
+}
+
static int intel_crtc_compute_pipe_mode(struct intel_crtc_state *crtc_state)
{
struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
@@ -2645,6 +2665,8 @@ static int intel_crtc_compute_config(struct intel_atomic_state *state,
if (ret)
return ret;
+ intel_crtc_compute_pfit(state, crtc_state);
+
intel_crtc_compute_pixel_rate(crtc_state);
if (crtc_state->has_pch_encoder)
--
2.25.1
next prev parent reply other threads:[~2024-11-20 5:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 5:38 [PATCH 0/6] Consider joiner calculation for panel fitting Nemesa Garg
2024-11-20 5:38 ` [PATCH 1/6] drm/i915/display: Disable joiner and pfit Nemesa Garg
2024-11-22 18:45 ` Ville Syrjälä
2024-11-20 5:38 ` [PATCH v5 2/6] drm/i915/display: Add gmch_panel_fitting in all encoders Nemesa Garg
2024-11-22 18:47 ` Ville Syrjälä
2024-11-22 18:48 ` Ville Syrjälä
2024-11-20 5:38 ` [PATCH 3/6] drm/i915/display: Replace adjusted mode with pipe mode Nemesa Garg
2024-11-22 20:01 ` Ville Syrjälä
2024-12-11 9:19 ` Garg, Nemesa
2024-11-20 5:38 ` Nemesa Garg [this message]
2024-11-20 5:38 ` [PATCH 5/6] drm/i915/dispaly: Allow joiner and pfit Nemesa Garg
2024-11-20 5:38 ` [PATCH 6/6] drm/i915/display: Initialize pipe_src in compute stage Nemesa Garg
2024-11-20 5:49 ` ✓ CI.Patch_applied: success for Consider joiner calculation for panel fitting Patchwork
2024-11-20 5:49 ` ✓ CI.checkpatch: " Patchwork
2024-11-20 5:51 ` ✓ CI.KUnit: " Patchwork
2024-11-20 6:09 ` ✓ CI.Build: " Patchwork
2024-11-20 6:11 ` ✓ CI.Hooks: " Patchwork
2024-11-20 6:12 ` ✗ CI.checksparse: warning " Patchwork
2024-11-20 6:33 ` ✗ CI.BAT: failure " Patchwork
2024-11-20 17:04 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120053838.3794419-5-nemesa.garg@intel.com \
--to=nemesa.garg@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox