Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH] drm/i915/hdcp: Remove log for HDMI HDCP LIC check
Date: Mon,  2 Dec 2024 11:34:10 +0530	[thread overview]
Message-ID: <20241202060410.1872121-1-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20241129090530.1814774-1-suraj.kandpal@intel.com>

We don't need to shout out loud if there is a Link Integrity
Failure. This does not mean HDCP has failed, it is expected and
taken into account in the HDCP Spec. The real failure happens when
we are not able to reauthenticate and get HDCP running again for
which we already have the right logging.

--v2
-Remove the log altogether [Ankit]

--v3
-Remove useless display variable

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_hdmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 23c270a8c4aa..63e56c9ff516 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -1600,14 +1600,12 @@ static
 bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
 				struct intel_connector *connector)
 {
-	struct intel_display *display = to_intel_display(dig_port);
 	int retry;
 
 	for (retry = 0; retry < 3; retry++)
 		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
 			return true;
 
-	drm_err(display->drm, "Link check failed\n");
 	return false;
 }
 
-- 
2.34.1


  parent reply	other threads:[~2024-12-02  6:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-29  9:05 [PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check Suraj Kandpal
2024-11-29  9:10 ` ✓ CI.Patch_applied: success for drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev2) Patchwork
2024-11-29  9:10 ` ✓ CI.checkpatch: " Patchwork
2024-11-29  9:12 ` ✓ CI.KUnit: " Patchwork
2024-11-29  9:19 ` ✗ CI.Build: failure " Patchwork
2024-11-29 12:43 ` [PATCH] drm/i915/hdcp: Change log level for HDMI HDCP LIC check kernel test robot
2024-12-02  6:04 ` Suraj Kandpal [this message]
2024-12-02  8:26   ` [PATCH] drm/i915/hdcp: Remove log " Nautiyal, Ankit K
2024-12-02  6:11 ` ✓ CI.Patch_applied: success for drm/i915/hdcp: Change log level for HDMI HDCP LIC check (rev3) Patchwork
2024-12-02  6:12 ` ✓ CI.checkpatch: " Patchwork
2024-12-02  6:13 ` ✓ CI.KUnit: " Patchwork
2024-12-02  6:31 ` ✓ CI.Build: " Patchwork
2024-12-02  6:34 ` ✓ CI.Hooks: " Patchwork
2024-12-02  6:35 ` ✗ CI.checksparse: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202060410.1872121-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox