Re: [PATCH] drm/i915/hdcp: Remove log for HDMI HDCP LIC check

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 12/2/2024 11:34 AM, Suraj Kandpal wrote:
> We don't need to shout out loud if there is a Link Integrity
> Failure. This does not mean HDCP has failed, it is expected and
> taken into account in the HDCP Spec. The real failure happens when
> we are not able to reauthenticate and get HDCP running again for
> which we already have the right logging.
>
> --v2
> -Remove the log altogether [Ankit]
>
> --v3
> -Remove useless display variable
>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>

LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

> ---
>   drivers/gpu/drm/i915/display/intel_hdmi.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 23c270a8c4aa..63e56c9ff516 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1600,14 +1600,12 @@ static
>   bool intel_hdmi_hdcp_check_link(struct intel_digital_port *dig_port,
>   				struct intel_connector *connector)
>   {
> -	struct intel_display *display = to_intel_display(dig_port);
>   	int retry;
>   
>   	for (retry = 0; retry < 3; retry++)
>   		if (intel_hdmi_hdcp_check_link_once(dig_port, connector))
>   			return true;
>   
> -	drm_err(display->drm, "Link check failed\n");
>   	return false;
>   }
>