Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com, jonathan.cavitt@intel.com
Subject: [PATCH] drm/xe/xe_sync: Add debug printing to check_ufence
Date: Mon,  2 Dec 2024 19:46:31 +0000	[thread overview]
Message-ID: <20241202194631.106940-1-jonathan.cavitt@intel.com> (raw)

The xe_sync helper function check_ufence can occasionally report EBUSY
if the ufence has not been signalled yet.  EBUSY is a non-fatal error
value for the function, so it is not desireable to warn in cases where
EBUSY is reported because it is up to the user to decide if EBUSY is a
fatal error in their use cases.  However, we can and should report EBUSY
to the debug logs for diagnostic purposes.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/xe/xe_vm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 610226c7c1ce..09ab7111e091 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2400,7 +2400,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
 		break;
 	case DRM_GPUVA_OP_REMAP:
 		err = check_ufence(gpuva_to_vma(op->base.remap.unmap->va));
-		if (err)
+		if (XE_IOCTL_DBG(vm->xe, err))
 			break;
 
 		err = vma_lock_and_validate(exec,
@@ -2413,7 +2413,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
 		break;
 	case DRM_GPUVA_OP_UNMAP:
 		err = check_ufence(gpuva_to_vma(op->base.unmap.va));
-		if (err)
+		if (XE_IOCTL_DBG(vm->xe, err))
 			break;
 
 		err = vma_lock_and_validate(exec,
-- 
2.43.0


             reply	other threads:[~2024-12-02 19:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 19:46 Jonathan Cavitt [this message]
2024-12-02 20:10 ` ✓ CI.Patch_applied: success for drm/xe/xe_sync: Add debug printing to check_ufence Patchwork
2024-12-02 20:11 ` ✓ CI.checkpatch: " Patchwork
2024-12-02 20:13 ` ✓ CI.KUnit: " Patchwork
2024-12-02 20:31 ` ✓ CI.Build: " Patchwork
2024-12-02 20:34 ` ✓ CI.Hooks: " Patchwork
2024-12-02 20:36 ` ✓ CI.checksparse: " Patchwork
2024-12-02 20:57 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-02 22:28 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-06 15:25 ` [PATCH] " Rodrigo Vivi
2024-12-06 18:09   ` Cavitt, Jonathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241202194631.106940-1-jonathan.cavitt@intel.com \
    --to=jonathan.cavitt@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=saurabhg.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox