Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/xe_sync: Add debug printing to check_ufence
@ 2024-12-02 19:46 Jonathan Cavitt
  2024-12-02 20:10 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Jonathan Cavitt @ 2024-12-02 19:46 UTC (permalink / raw)
  To: intel-xe; +Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt

The xe_sync helper function check_ufence can occasionally report EBUSY
if the ufence has not been signalled yet.  EBUSY is a non-fatal error
value for the function, so it is not desireable to warn in cases where
EBUSY is reported because it is up to the user to decide if EBUSY is a
fatal error in their use cases.  However, we can and should report EBUSY
to the debug logs for diagnostic purposes.

Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
---
 drivers/gpu/drm/xe/xe_vm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index 610226c7c1ce..09ab7111e091 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -2400,7 +2400,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
 		break;
 	case DRM_GPUVA_OP_REMAP:
 		err = check_ufence(gpuva_to_vma(op->base.remap.unmap->va));
-		if (err)
+		if (XE_IOCTL_DBG(vm->xe, err))
 			break;
 
 		err = vma_lock_and_validate(exec,
@@ -2413,7 +2413,7 @@ static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
 		break;
 	case DRM_GPUVA_OP_UNMAP:
 		err = check_ufence(gpuva_to_vma(op->base.unmap.va));
-		if (err)
+		if (XE_IOCTL_DBG(vm->xe, err))
 			break;
 
 		err = vma_lock_and_validate(exec,
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-12-06 18:09 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 19:46 [PATCH] drm/xe/xe_sync: Add debug printing to check_ufence Jonathan Cavitt
2024-12-02 20:10 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-02 20:11 ` ✓ CI.checkpatch: " Patchwork
2024-12-02 20:13 ` ✓ CI.KUnit: " Patchwork
2024-12-02 20:31 ` ✓ CI.Build: " Patchwork
2024-12-02 20:34 ` ✓ CI.Hooks: " Patchwork
2024-12-02 20:36 ` ✓ CI.checksparse: " Patchwork
2024-12-02 20:57 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-02 22:28 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-06 15:25 ` [PATCH] " Rodrigo Vivi
2024-12-06 18:09   ` Cavitt, Jonathan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox