Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/guc: Fix for dead CT dump not re-arming
@ 2024-12-03  0:59 John.C.Harrison
  2024-12-03  1:07 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: John.C.Harrison @ 2024-12-03  0:59 UTC (permalink / raw)
  To: Intel-Xe; +Cc: John Harrison

From: John Harrison <John.C.Harrison@Intel.com>

The state dump on a dead CT incident deliberately disarms itself after
running. This is to prevent a long stream of errors causing continuous
dumps. It was supposed to re-arm itself after a reset, however that
was not happening. The re-arm flag was being set but the worker was
not being run to process that flag. So fix that.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 7eb175a0b874..7d33f3a11e61 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -470,8 +470,10 @@ int xe_guc_ct_enable(struct xe_guc_ct *ct)
 	 * after any existing dead state has been dumped.
 	 */
 	spin_lock_irq(&ct->dead.lock);
-	if (ct->dead.reason)
+	if (ct->dead.reason) {
 		ct->dead.reason |= (1 << CT_DEAD_STATE_REARM);
+		queue_work(system_unbound_wq, &ct->dead.worker);
+	}
 	spin_unlock_irq(&ct->dead.lock);
 #endif
 
-- 
2.47.0


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-12-05 21:18 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03  0:59 [PATCH] drm/xe/guc: Fix for dead CT dump not re-arming John.C.Harrison
2024-12-03  1:07 ` ✓ CI.Patch_applied: success for " Patchwork
2024-12-03  1:07 ` ✓ CI.checkpatch: " Patchwork
2024-12-03  1:09 ` ✓ CI.KUnit: " Patchwork
2024-12-03  1:28 ` ✓ CI.Build: " Patchwork
2024-12-03  1:30 ` ✓ CI.Hooks: " Patchwork
2024-12-03  1:31 ` ✓ CI.checksparse: " Patchwork
2024-12-03  1:52 ` ✓ Xe.CI.BAT: " Patchwork
2024-12-03  2:47 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-05 21:18 ` [PATCH] " Julia Filipchuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox