Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: mitulkumar.ajitkumar.golani@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 1/6] drm/i915/wm: Initialize max_latency variable to appropriate value
Date: Tue,  3 Dec 2024 14:17:01 +0530	[thread overview]
Message-ID: <20241203084706.2126189-1-suraj.kandpal@intel.com> (raw)

Initialize max_latency variable to LNL_PKG_C_LATENCY_MASK which helps
to eliminate the else block and make the whole code a lot cleaner.

--v2
-Seprate patch to club variables together [Mitul]

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/skl_watermark.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 1a4c1fa24820..c40e0173a5bd 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -2857,7 +2857,7 @@ static int skl_wm_add_affected_planes(struct intel_atomic_state *state,
 static void
 skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc)
 {
-	u32 max_latency = 0;
+	u32 max_latency = LNL_PKG_C_LATENCY_MASK;
 	u32 clear = 0, val = 0;
 	u32 added_wake_time = 0;
 
@@ -2870,9 +2870,6 @@ skl_program_dpkgc_latency(struct drm_i915_private *i915, bool enable_dpkgc)
 			max_latency = LNL_PKG_C_LATENCY_MASK;
 		added_wake_time = DSB_EXE_TIME +
 			i915->display.sagv.block_time_us;
-	} else {
-		max_latency = LNL_PKG_C_LATENCY_MASK;
-		added_wake_time = 0;
 	}
 
 	clear |= LNL_ADDED_WAKE_TIME_MASK | LNL_PKG_C_LATENCY_MASK;
-- 
2.34.1


             reply	other threads:[~2024-12-03  8:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03  8:47 Suraj Kandpal [this message]
2024-12-03  8:47 ` [PATCH 2/6] drm/i915/wm: Refactor dpkgc value prepration Suraj Kandpal
2024-12-05  2:07   ` Golani, Mitulkumar Ajitkumar
2024-12-03  8:47 ` [PATCH 3/6] drm/i915/wm: Use intel_display structure in DPKGC code Suraj Kandpal
2024-12-03  8:47 ` [PATCH 4/6] drm/i915/display: Refactor DPKGC code to call it from atomic_commit_tail Suraj Kandpal
2024-12-03  8:47 ` [PATCH 5/6] drm/i915/wm: Modify latency programmed into PKG_C_LATENCY Suraj Kandpal
2024-12-05  1:53   ` Golani, Mitulkumar Ajitkumar
2024-12-03  8:47 ` [PATCH 6/6] drm/i915/wm: Club the initialized variables together Suraj Kandpal
2024-12-05  1:58   ` Golani, Mitulkumar Ajitkumar
2024-12-05  2:03     ` Kandpal, Suraj
2024-12-05  2:12       ` Golani, Mitulkumar Ajitkumar
2024-12-03  8:52 ` ✓ CI.Patch_applied: success for series starting with [1/6] drm/i915/wm: Initialize max_latency variable to appropriate value Patchwork
2024-12-03  8:53 ` ✓ CI.checkpatch: " Patchwork
2024-12-03  8:54 ` ✓ CI.KUnit: " Patchwork
2024-12-03  9:12 ` ✓ CI.Build: " Patchwork
2024-12-03  9:14 ` ✓ CI.Hooks: " Patchwork
2024-12-03  9:16 ` ✗ CI.checksparse: warning " Patchwork
2024-12-03  9:36 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-03 10:30 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-05  1:35 ` [PATCH 1/6] " Golani, Mitulkumar Ajitkumar
  -- strict thread matches above, loose matches on Subject: below --
2024-11-15 16:01 Suraj Kandpal
2024-12-02  9:15 ` Golani, Mitulkumar Ajitkumar
2024-12-02  9:17   ` Kandpal, Suraj
2024-12-02  9:42 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241203084706.2126189-1-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mitulkumar.ajitkumar.golani@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox