From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: mitulkumar.ajitkumar.golani@intel.com,
Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 5/6] drm/i915/wm: Modify latency programmed into PKG_C_LATENCY
Date: Tue, 3 Dec 2024 14:17:05 +0530 [thread overview]
Message-ID: <20241203084706.2126189-5-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20241203084706.2126189-1-suraj.kandpal@intel.com>
Increase the latency programmed into PKG_C_LATENCY latency to be
a multiple of line time which is written into WM_LINETIME.
--v2
-Fix commit subject line [Sai Teja]
-Use individual DISPLAY_VER checks instead of range [Sai Teja]
-Initialize max_linetime [Sai Teja]
--v3
-take into account the scenario when adjusted_latency is 0 [Vinod]
--v4
-rename adjusted_latency to latency [Mitul]
-fix the condition in which dpkgc is disabled [Vinod]
--v5
-Add check to see if max_linetime is 0 [Vinod]
--v6
-Avoid nested if statements [Mitul]
WA: 22020299601
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
drivers/gpu/drm/i915/display/skl_watermark.c | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 95b306c22954..4c032b1758e7 100644
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -2861,7 +2861,8 @@ intel_program_dpkgc_latency(struct intel_atomic_state *state)
struct drm_i915_private *i915 = to_i915(display->drm);
struct intel_crtc *crtc;
struct intel_crtc_state *new_crtc_state;
- u32 max_latency = LNL_PKG_C_LATENCY_MASK;
+ u32 latency = LNL_PKG_C_LATENCY_MASK;
+ u32 max_linetime = 0;
u32 clear, val;
u32 added_wake_time = 0;
bool fixed_refresh_rate = false;
@@ -2875,18 +2876,26 @@ intel_program_dpkgc_latency(struct intel_atomic_state *state)
(new_crtc_state->vrr.vmin == new_crtc_state->vrr.vmax &&
new_crtc_state->vrr.vmin == new_crtc_state->vrr.flipline))
fixed_refresh_rate = true;
+
+ max_linetime = max(new_crtc_state->linetime, max_linetime);
}
if (fixed_refresh_rate) {
- max_latency = skl_watermark_max_latency(i915, 1);
- if (max_latency == 0)
- max_latency = LNL_PKG_C_LATENCY_MASK;
+ latency = skl_watermark_max_latency(i915, 1);
+ /* Wa_22020299601 */
+ if ((latency && max_linetime) &&
+ (DISPLAY_VER(display) == 20 || DISPLAY_VER(display) == 30)) {
+ latency = max_linetime * DIV_ROUND_UP(latency, max_linetime);
+ } else if (!latency) {
+ latency = LNL_PKG_C_LATENCY_MASK;
+ }
+
added_wake_time = DSB_EXE_TIME +
display->sagv.block_time_us;
}
clear = LNL_ADDED_WAKE_TIME_MASK | LNL_PKG_C_LATENCY_MASK;
- val = REG_FIELD_PREP(LNL_PKG_C_LATENCY_MASK, max_latency) |
+ val = REG_FIELD_PREP(LNL_PKG_C_LATENCY_MASK, latency) |
REG_FIELD_PREP(LNL_ADDED_WAKE_TIME_MASK, added_wake_time);
intel_de_rmw(display, LNL_PKG_C_LATENCY, clear, val);
--
2.34.1
next prev parent reply other threads:[~2024-12-03 8:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 8:47 [PATCH 1/6] drm/i915/wm: Initialize max_latency variable to appropriate value Suraj Kandpal
2024-12-03 8:47 ` [PATCH 2/6] drm/i915/wm: Refactor dpkgc value prepration Suraj Kandpal
2024-12-05 2:07 ` Golani, Mitulkumar Ajitkumar
2024-12-03 8:47 ` [PATCH 3/6] drm/i915/wm: Use intel_display structure in DPKGC code Suraj Kandpal
2024-12-03 8:47 ` [PATCH 4/6] drm/i915/display: Refactor DPKGC code to call it from atomic_commit_tail Suraj Kandpal
2024-12-03 8:47 ` Suraj Kandpal [this message]
2024-12-05 1:53 ` [PATCH 5/6] drm/i915/wm: Modify latency programmed into PKG_C_LATENCY Golani, Mitulkumar Ajitkumar
2024-12-03 8:47 ` [PATCH 6/6] drm/i915/wm: Club the initialized variables together Suraj Kandpal
2024-12-05 1:58 ` Golani, Mitulkumar Ajitkumar
2024-12-05 2:03 ` Kandpal, Suraj
2024-12-05 2:12 ` Golani, Mitulkumar Ajitkumar
2024-12-03 8:52 ` ✓ CI.Patch_applied: success for series starting with [1/6] drm/i915/wm: Initialize max_latency variable to appropriate value Patchwork
2024-12-03 8:53 ` ✓ CI.checkpatch: " Patchwork
2024-12-03 8:54 ` ✓ CI.KUnit: " Patchwork
2024-12-03 9:12 ` ✓ CI.Build: " Patchwork
2024-12-03 9:14 ` ✓ CI.Hooks: " Patchwork
2024-12-03 9:16 ` ✗ CI.checksparse: warning " Patchwork
2024-12-03 9:36 ` ✓ Xe.CI.BAT: success " Patchwork
2024-12-03 10:30 ` ✗ Xe.CI.Full: failure " Patchwork
2024-12-05 1:35 ` [PATCH 1/6] " Golani, Mitulkumar Ajitkumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203084706.2126189-5-suraj.kandpal@intel.com \
--to=suraj.kandpal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox