Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
To: intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com
Cc: michael.j.ruhl@intel.com
Subject: [PATCH] drm/xe/vsec: Address static checker issue
Date: Thu,  5 Dec 2024 13:36:49 -0500	[thread overview]
Message-ID: <20241205183649.3120032-1-michael.j.ruhl@intel.com> (raw)

The callback structure should be static.

Add static attribute.

NOTE: the fixes tag in the drm-tip context

Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412050418.8ecQxYXj-lkp@intel.com/
Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
---
 drivers/gpu/drm/xe/xe_vsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
index 17ebc3ffb573..edaec262ed0a 100644
--- a/drivers/gpu/drm/xe/xe_vsec.c
+++ b/drivers/gpu/drm/xe/xe_vsec.c
@@ -180,7 +180,7 @@ static int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t u
 	return count;
 }
 
-struct pmt_callbacks xe_pmt_cb = {
+static struct pmt_callbacks xe_pmt_cb = {
 	.read_telem = xe_pmt_telem_read,
 };
 
-- 
2.44.0


             reply	other threads:[~2024-12-05 18:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 18:36 Michael J. Ruhl [this message]
2024-12-05 20:32 ` ✓ CI.Patch_applied: success for drm/xe/vsec: Address static checker issue Patchwork
2024-12-05 20:32 ` ✓ CI.checkpatch: " Patchwork
2024-12-05 20:33 ` ✓ CI.KUnit: " Patchwork
2024-12-05 20:51 ` ✓ CI.Build: " Patchwork
2024-12-05 20:53 ` ✓ CI.Hooks: " Patchwork
2024-12-05 20:55 ` ✓ CI.checksparse: " Patchwork
2024-12-05 20:55 ` [PATCH] " Rodrigo Vivi
2024-12-05 21:16 ` ✓ Xe.CI.BAT: success for " Patchwork
2024-12-05 22:40 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241205183649.3120032-1-michael.j.ruhl@intel.com \
    --to=michael.j.ruhl@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox