Re: [PATCH] drm/xe/vsec: Address static checker issue

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Dec 05, 2024 at 01:36:49PM -0500, Michael J. Ruhl wrote:
> The callback structure should be static.
> 
> Add static attribute.
> 
> NOTE: the fixes tag in the drm-tip context

With this NOTE removed:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

(I will remove the NOTE while pushing it...)

> 
> Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412050418.8ecQxYXj-lkp@intel.com/
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index 17ebc3ffb573..edaec262ed0a 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
> @@ -180,7 +180,7 @@ static int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t u
>  	return count;
>  }
>  
> -struct pmt_callbacks xe_pmt_cb = {
> +static struct pmt_callbacks xe_pmt_cb = {
>  	.read_telem = xe_pmt_telem_read,
>  };
>  
> -- 
> 2.44.0
>