From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [PATCH 3/3] drm/i915/dmc_wl: Track pipe interrupt registers
Date: Fri, 3 Jan 2025 14:41:37 -0300 [thread overview]
Message-ID: <20250103174223.58140-4-gustavo.sousa@intel.com> (raw)
In-Reply-To: <20250103174223.58140-1-gustavo.sousa@intel.com>
Pipe interrupt registers live in their respective pipes' power wells,
which are below PG0. That means that they must also be tracked as
registers that are powered-off during dynamic DC states.
There are probably more ranges that we need to track down and add to the
powered_off_ranges. However, let's make this change only about pipe
interrupt registers to fix some vblank timeouts observed due to the DMC
wakelock not being taken for those registers.
In the future, we might want to replace powered_off_ranges with a new
table to represent registers in PG0, which should be probably easier to
maintain. Any register not belonging to that table should be considered
powered off during dynamic DC states and, as such, requiring the DMC
wakelock for access.
Bspec: 72519, 71583
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/i915/display/intel_dmc_wl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc_wl.c b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
index 02de3ae15074..985aa968692e 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc_wl.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc_wl.c
@@ -56,6 +56,7 @@ struct intel_dmc_wl_range {
};
static const struct intel_dmc_wl_range powered_off_ranges[] = {
+ { .start = 0x44400, .end = 0x4447f }, /* PIPE interrupt registers */
{ .start = 0x60000, .end = 0x7ffff },
{},
};
--
2.47.1
next prev parent reply other threads:[~2025-01-03 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-03 17:41 [PATCH 0/3] drm/i915/dmc_wl: Track pipe interrupt registers Gustavo Sousa
2025-01-03 17:41 ` [PATCH 1/3] drm/i915/display: Use display MMIO functions in intel_display_irq.c Gustavo Sousa
2025-01-09 7:03 ` Hogander, Jouni
2025-01-03 17:41 ` [PATCH 2/3] drm/i915/display: Wrap IRQ-specific uncore functions Gustavo Sousa
2025-01-07 9:16 ` Jani Nikula
2025-01-13 20:51 ` Gustavo Sousa
2025-01-03 17:41 ` Gustavo Sousa [this message]
2025-01-09 7:07 ` [PATCH 3/3] drm/i915/dmc_wl: Track pipe interrupt registers Hogander, Jouni
2025-01-03 18:30 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-03 18:31 ` ✓ CI.checkpatch: " Patchwork
2025-01-03 18:32 ` ✓ CI.KUnit: " Patchwork
2025-01-03 18:50 ` ✓ CI.Build: " Patchwork
2025-01-03 18:52 ` ✓ CI.Hooks: " Patchwork
2025-01-03 18:54 ` ✗ CI.checksparse: warning " Patchwork
2025-01-03 19:19 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-04 2:30 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250103174223.58140-4-gustavo.sousa@intel.com \
--to=gustavo.sousa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox