From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH 1/4] drm/i915/psr: Add new function for writing sink panel replay enable bit
Date: Thu, 9 Jan 2025 12:35:29 +0200 [thread overview]
Message-ID: <20250109103532.2093356-2-jouni.hogander@intel.com> (raw)
In-Reply-To: <20250109103532.2093356-1-jouni.hogander@intel.com>
According to DP/eDP specification only DP_PANEL_REPLAY_ENABLE has to be set
prior link training. For this purpose add a new function which sets this
bit on sink side if Panel Replay is supported by the sink and the source.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 7 +++++++
drivers/gpu/drm/i915/display/intel_psr.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 64c00a8a6850..e592bc01c7fb 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -827,6 +827,13 @@ void intel_psr_enable_sink(struct intel_dp *intel_dp,
drm_dp_dpcd_writeb(&intel_dp->aux, DP_SET_POWER, DP_SET_POWER_D0);
}
+void intel_psr_panel_replay_enable_sink(struct intel_dp *intel_dp)
+{
+ if (CAN_PANEL_REPLAY(intel_dp))
+ drm_dp_dpcd_writeb(&intel_dp->aux, PANEL_REPLAY_CONFIG,
+ DP_PANEL_REPLAY_ENABLE);
+}
+
static u32 intel_psr1_get_tp_time(struct intel_dp *intel_dp)
{
struct intel_display *display = to_intel_display(intel_dp);
diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
index 956be263c09e..3b2643b83e06 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.h
+++ b/drivers/gpu/drm/i915/display/intel_psr.h
@@ -30,6 +30,7 @@ bool intel_psr_needs_aux_io_power(struct intel_encoder *encoder,
void intel_psr_init_dpcd(struct intel_dp *intel_dp);
void intel_psr_enable_sink(struct intel_dp *intel_dp,
const struct intel_crtc_state *crtc_state);
+void intel_psr_panel_replay_enable_sink(struct intel_dp *intel_dp);
void intel_psr_pre_plane_update(struct intel_atomic_state *state,
struct intel_crtc *crtc);
void intel_psr_post_plane_update(struct intel_atomic_state *state,
--
2.34.1
next prev parent reply other threads:[~2025-01-09 10:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 10:35 [PATCH 0/4] Panel Replay mode change without full modeset Jouni Högander
2025-01-09 10:35 ` Jouni Högander [this message]
2025-01-13 11:04 ` [PATCH 1/4] drm/i915/psr: Add new function for writing sink panel replay enable bit Kahola, Mika
2025-01-09 10:35 ` [PATCH 2/4] drm/i915/psr: Enable Panel Replay on sink always when it's supported Jouni Högander
2025-01-13 11:06 ` Kahola, Mika
2025-01-09 10:35 ` [PATCH 3/4] drm/i915/psr: Make intel_psr_enable_sink as local static function Jouni Högander
2025-01-13 11:06 ` Kahola, Mika
2025-01-09 10:35 ` [PATCH 4/4] drm/i915/psr: Allow changing Panel Replay mode without full modeset Jouni Högander
2025-01-13 11:22 ` Kahola, Mika
2025-01-21 10:08 ` Hogander, Jouni
2025-01-09 11:28 ` ✓ CI.Patch_applied: success for Panel Replay mode change " Patchwork
2025-01-09 11:28 ` ✓ CI.checkpatch: " Patchwork
2025-01-09 11:29 ` ✓ CI.KUnit: " Patchwork
2025-01-09 11:47 ` ✓ CI.Build: " Patchwork
2025-01-09 11:50 ` ✓ CI.Hooks: " Patchwork
2025-01-09 11:51 ` ✗ CI.checksparse: warning " Patchwork
2025-01-20 14:12 ` ✓ CI.Patch_applied: success for Panel Replay mode change without full modeset (rev2) Patchwork
2025-01-20 14:12 ` ✓ CI.checkpatch: " Patchwork
2025-01-20 14:13 ` ✓ CI.KUnit: " Patchwork
2025-01-20 14:29 ` ✓ CI.Build: " Patchwork
2025-01-20 14:32 ` ✓ CI.Hooks: " Patchwork
2025-01-20 14:33 ` ✗ CI.checksparse: warning " Patchwork
2025-01-20 15:20 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-20 18:12 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 8:13 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109103532.2093356-2-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox