From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>
Subject: [PATCH 2/4] drm/i915/psr: Enable Panel Replay on sink always when it's supported
Date: Thu, 9 Jan 2025 12:35:30 +0200 [thread overview]
Message-ID: <20250109103532.2093356-3-jouni.hogander@intel.com> (raw)
In-Reply-To: <20250109103532.2093356-1-jouni.hogander@intel.com>
Currently we are configuring Panel Replay on sink when it get's
enabled. This means we need to do full modeset when enabling Panel
Replay. This is required as DP specification is saying sink Panel Replay
needs to be configured before link training. Avoid full modeset by enabling
Panel Replay on sink always when it's supported by the sink and the
source.
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
---
drivers/gpu/drm/i915/display/intel_ddi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 4f9c50996446..b0ea56e166c5 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2890,8 +2890,7 @@ static void intel_ddi_pre_enable_dp(struct intel_atomic_state *state,
crtc_state);
/* Panel replay has to be enabled in sink dpcd before link training. */
- if (crtc_state->has_panel_replay)
- intel_psr_enable_sink(enc_to_intel_dp(encoder), crtc_state);
+ intel_psr_panel_replay_enable_sink(enc_to_intel_dp(encoder));
if (DISPLAY_VER(display) >= 14)
mtl_ddi_pre_enable_dp(state, encoder, crtc_state, conn_state);
--
2.34.1
next prev parent reply other threads:[~2025-01-09 10:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-09 10:35 [PATCH 0/4] Panel Replay mode change without full modeset Jouni Högander
2025-01-09 10:35 ` [PATCH 1/4] drm/i915/psr: Add new function for writing sink panel replay enable bit Jouni Högander
2025-01-13 11:04 ` Kahola, Mika
2025-01-09 10:35 ` Jouni Högander [this message]
2025-01-13 11:06 ` [PATCH 2/4] drm/i915/psr: Enable Panel Replay on sink always when it's supported Kahola, Mika
2025-01-09 10:35 ` [PATCH 3/4] drm/i915/psr: Make intel_psr_enable_sink as local static function Jouni Högander
2025-01-13 11:06 ` Kahola, Mika
2025-01-09 10:35 ` [PATCH 4/4] drm/i915/psr: Allow changing Panel Replay mode without full modeset Jouni Högander
2025-01-13 11:22 ` Kahola, Mika
2025-01-21 10:08 ` Hogander, Jouni
2025-01-09 11:28 ` ✓ CI.Patch_applied: success for Panel Replay mode change " Patchwork
2025-01-09 11:28 ` ✓ CI.checkpatch: " Patchwork
2025-01-09 11:29 ` ✓ CI.KUnit: " Patchwork
2025-01-09 11:47 ` ✓ CI.Build: " Patchwork
2025-01-09 11:50 ` ✓ CI.Hooks: " Patchwork
2025-01-09 11:51 ` ✗ CI.checksparse: warning " Patchwork
2025-01-20 14:12 ` ✓ CI.Patch_applied: success for Panel Replay mode change without full modeset (rev2) Patchwork
2025-01-20 14:12 ` ✓ CI.checkpatch: " Patchwork
2025-01-20 14:13 ` ✓ CI.KUnit: " Patchwork
2025-01-20 14:29 ` ✓ CI.Build: " Patchwork
2025-01-20 14:32 ` ✓ CI.Hooks: " Patchwork
2025-01-20 14:33 ` ✗ CI.checksparse: warning " Patchwork
2025-01-20 15:20 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-20 18:12 ` ✗ Xe.CI.Full: failure " Patchwork
2025-01-21 8:13 ` Hogander, Jouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250109103532.2093356-3-jouni.hogander@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox