Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/guc/slpc: Allow GuC SLPC default strategies on MTL+
@ 2025-01-09 22:57 Rodrigo Vivi
  2025-01-09 22:57 ` [PATCH 2/2] drm/i915/guc/slpc: Print more SLPC debug status information Rodrigo Vivi
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2025-01-09 22:57 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Vinay Belgaumkar

The Balancer and DCC strategies were left off on a fear that
these strategies would conflict with the i915's waitboost.

However, on MTL and Beyond these strategies are only active in
certain conditions where the system is TDP limited.
So, they don't conflict, but help the
waitboost by guaranteeing a bit more of GT frequency.

Without these strategies we were likely leaving some performance
behind on some scenarios.

With this change in place, the enabling/disabling of DCC and Balancer
will now be chosen by GuC, on a platform/GT basis.

v2: - Fix typos and be clear on GuC decision on platform basis (Vinay)
    - Limit change to MTL and beyond, where GuC started to take
      TDP limit into consideration.

Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> #v1
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
index 706fffca698b..f05c92e08d9b 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
@@ -367,11 +367,17 @@ static void slpc_shared_data_reset(struct slpc_shared_data *data)
 	slpc_mem_set_enabled(data, SLPC_PARAM_TASK_ENABLE_GTPERF,
 			     SLPC_PARAM_TASK_DISABLE_GTPERF);
 
-	slpc_mem_set_disabled(data, SLPC_PARAM_TASK_ENABLE_BALANCER,
-			      SLPC_PARAM_TASK_DISABLE_BALANCER);
+	/*
+	 * Don't allow balancer related algorithms on platforms before
+	 * Xe_LPG, where GuC started to restrict it to TDP limited scenarios.
+	 */
+	if (GRAPHICS_VER_FULL(gt->i915) < IP_VER(12, 70)) {
+		slpc_mem_set_disabled(data, SLPC_PARAM_TASK_ENABLE_BALANCER,
+				      SLPC_PARAM_TASK_DISABLE_BALANCER);
 
-	slpc_mem_set_disabled(data, SLPC_PARAM_TASK_ENABLE_DCC,
-			      SLPC_PARAM_TASK_DISABLE_DCC);
+		slpc_mem_set_disabled(data, SLPC_PARAM_TASK_ENABLE_DCC,
+				      SLPC_PARAM_TASK_DISABLE_DCC);
+	}
 }
 
 /**
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-01-09 23:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 22:57 [PATCH 1/2] drm/i915/guc/slpc: Allow GuC SLPC default strategies on MTL+ Rodrigo Vivi
2025-01-09 22:57 ` [PATCH 2/2] drm/i915/guc/slpc: Print more SLPC debug status information Rodrigo Vivi
2025-01-09 23:38 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/i915/guc/slpc: Allow GuC SLPC default strategies on MTL+ Patchwork
2025-01-09 23:38 ` ✓ CI.checkpatch: " Patchwork
2025-01-09 23:39 ` ✓ CI.KUnit: " Patchwork
2025-01-09 23:46 ` ✗ CI.Build: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox