Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [PATCH 0/4] drm/i915/dmc_wl: Introduce debugfs interface
Date: Fri, 17 Jan 2025 19:06:51 -0300	[thread overview]
Message-ID: <20250117220747.87927-1-gustavo.sousa@intel.com> (raw)

The DMC wakelock code needs to keep track of register offsets that need
the wakelock for proper access. If one of the necessary offsets are
missed, then the failure in asserting the wakelock is very likely to
cause problems down the road.

A miss could happen for at least two different reasons:

- We might have forgotten to add the offset (or range) to the relevant
  tables tracked by the driver in the first place.

- Or updates to either the DMC firmware or the display IP that require
  new offsets to be tracked and we fail to realize that.

To help capture these cases, let's introduce a debugfs interface for the
DMC wakelock. The debugfs exports a file for looking up untracked
offsets and another for defining extra ranges to be tracked by our
driver during runtime, without the need of edit+re-compile+re-load
cycle.

See the added documentation and commit message for details.

Gustavo Sousa (4):
  drm/i915/dmc_wl: Pass offset instead of reg to range table iterator
  drm/i915/dmc_wl: Add debugfs for untracked offsets
  drm/i915/dmc_wl: Add extra_ranges debugfs
  drm/i915/dmc_wl: Enable the debugfs only with enable_dmc_wl_debugfs=1

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_display_debugfs.c  |   2 +
 .../drm/i915/display/intel_display_params.c   |   5 +
 .../drm/i915/display/intel_display_params.h   |   1 +
 drivers/gpu/drm/i915/display/intel_dmc_wl.c   |  23 +-
 drivers/gpu/drm/i915/display/intel_dmc_wl.h   |   2 +
 .../drm/i915/display/intel_dmc_wl_debugfs.c   | 517 ++++++++++++++++++
 .../drm/i915/display/intel_dmc_wl_debugfs.h   |  36 ++
 drivers/gpu/drm/xe/Makefile                   |   1 +
 9 files changed, 581 insertions(+), 7 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl_debugfs.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl_debugfs.h

-- 
2.48.0


             reply	other threads:[~2025-01-17 22:08 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 22:06 Gustavo Sousa [this message]
2025-01-17 22:06 ` [PATCH 1/4] drm/i915/dmc_wl: Pass offset instead of reg to range table iterator Gustavo Sousa
2025-01-22  8:23   ` Luca Coelho
2025-01-17 22:06 ` [PATCH 2/4] drm/i915/dmc_wl: Add debugfs for untracked offsets Gustavo Sousa
2025-01-22  9:06   ` Luca Coelho
2025-01-23 14:41     ` Gustavo Sousa
2025-01-30  9:33       ` Luca Coelho
2025-01-23 16:11   ` Vivekanandan, Balasubramani
2025-01-23 16:41     ` Gustavo Sousa
2025-01-30  8:54       ` Vivekanandan, Balasubramani
2025-01-27  9:47   ` Jani Nikula
2025-01-27 11:17     ` Gustavo Sousa
2025-01-27 11:59       ` Jani Nikula
2025-01-27 12:55         ` Gustavo Sousa
2025-01-17 22:06 ` [PATCH 3/4] drm/i915/dmc_wl: Add extra_ranges debugfs Gustavo Sousa
2025-01-22 10:19   ` Luca Coelho
2025-01-23 15:52     ` Gustavo Sousa
2025-01-30  9:18       ` Luca Coelho
2025-01-30  8:30   ` Vivekanandan, Balasubramani
2025-01-30  8:49     ` Vivekanandan, Balasubramani
2025-01-17 22:06 ` [PATCH 4/4] drm/i915/dmc_wl: Enable the debugfs only with enable_dmc_wl_debugfs=1 Gustavo Sousa
2025-01-22 10:24   ` Luca Coelho
2025-01-23 16:10     ` Gustavo Sousa
2025-01-30  9:28       ` Luca Coelho
2025-01-27 12:01   ` Jani Nikula
2025-01-27 12:02     ` Jani Nikula
2025-01-27 13:24     ` Gustavo Sousa
2025-01-27 13:35       ` Jani Nikula
2025-01-27 13:50         ` Gustavo Sousa
2025-01-27 14:40           ` Jani Nikula
2025-01-30  8:46   ` Vivekanandan, Balasubramani
2025-01-17 22:14 ` ✓ CI.Patch_applied: success for drm/i915/dmc_wl: Introduce debugfs interface Patchwork
2025-01-17 22:15 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-17 22:16 ` ✓ CI.KUnit: success " Patchwork
2025-01-17 22:34 ` ✓ CI.Build: " Patchwork
2025-01-17 22:36 ` ✓ CI.Hooks: " Patchwork
2025-01-17 22:38 ` ✓ CI.checksparse: " Patchwork
2025-01-17 23:06 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-18 13:06 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117220747.87927-1-gustavo.sousa@intel.com \
    --to=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox