Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/fbdev: Discard large BIOS framebuffers
@ 2025-01-21 10:42 Atharva Tiwari
  2025-01-21 12:05 ` Jani Nikula
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Atharva Tiwari @ 2025-01-21 10:42 UTC (permalink / raw)
  Cc: evepolonium, Jani Nikula, Rodrigo Vivi, Joonas Lahtinen,
	Tvrtko Ursulin, David Airlie, Simona Vetter, intel-gfx, intel-xe,
	dri-devel, linux-kernel

On certain 4K panels, the BIOS framebuffer
exceeds the panel's required dimensions,
leading to display corruption.
This patch introduces a validation check to address the issue.

Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
 drivers/gpu/drm/i915/display/intel_fbdev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 00852ff5b247..e8cf06772c31 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -197,10 +197,10 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	ifbdev->fb = NULL;
 
 	if (fb &&
-	    (sizes->fb_width > fb->base.width ||
-	     sizes->fb_height > fb->base.height)) {
+	    (sizes->fb_width != fb->base.width ||
+	     sizes->fb_height != fb->base.height)) {
 		drm_dbg_kms(&dev_priv->drm,
-			    "BIOS fb too small (%dx%d), we require (%dx%d),"
+			    "BIOS fb dimensions mismatch (%dx%d), we require (%dx%d),"
 			    " releasing it\n",
 			    fb->base.width, fb->base.height,
 			    sizes->fb_width, sizes->fb_height);
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-01-21 23:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-21 10:42 [PATCH] drm/i915/fbdev: Discard large BIOS framebuffers Atharva Tiwari
2025-01-21 12:05 ` Jani Nikula
2025-01-21 16:59 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-21 17:00 ` ✓ CI.checkpatch: " Patchwork
2025-01-21 17:02 ` ✓ CI.KUnit: " Patchwork
2025-01-21 17:19 ` ✓ CI.Build: " Patchwork
2025-01-21 17:21 ` ✓ CI.Hooks: " Patchwork
2025-01-21 17:22 ` ✓ CI.checksparse: " Patchwork
2025-01-21 17:49 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-21 23:10 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox