Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 2/5] drm/i915: Use more optimal VTd alignment for planes
Date: Wed, 22 Jan 2025 17:17:52 +0200	[thread overview]
Message-ID: <20250122151755.6928-3-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250122151755.6928-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Depending on the platform and/or plane type we can get away
with a bit less alignment in the VT-d w/a. Reduce the numbers
accordingly.

Note that it's not actually clear in VLV/CHV need this w/a,
and if they do we don't actually know what kind of alignment
is sufficient. Leave the 256k alignment in place for now, but
toss in a FIXME.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/i9xx_plane.c   | 1 +
 drivers/gpu/drm/i915/display/intel_cursor.c | 2 +-
 drivers/gpu/drm/i915/display/intel_sprite.c | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 19cc34babef3..65a2eb9e92c4 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -785,6 +785,7 @@ unsigned int vlv_plane_min_alignment(struct intel_plane *plane,
 	if (intel_plane_can_async_flip(plane, fb->modifier))
 		return 256 * 1024;
 
+	/* FIXME undocumented so not sure what's actually needed */
 	if (intel_scanout_needs_vtd_wa(i915))
 		return 256 * 1024;
 
diff --git a/drivers/gpu/drm/i915/display/intel_cursor.c b/drivers/gpu/drm/i915/display/intel_cursor.c
index 9157825e370b..ea7cd7b5093c 100644
--- a/drivers/gpu/drm/i915/display/intel_cursor.c
+++ b/drivers/gpu/drm/i915/display/intel_cursor.c
@@ -375,7 +375,7 @@ static unsigned int i9xx_cursor_min_alignment(struct intel_plane *plane,
 	struct drm_i915_private *i915 = to_i915(plane->base.dev);
 
 	if (intel_scanout_needs_vtd_wa(i915))
-		return 256 * 1024;
+		return 64 * 1024;
 
 	return 4 * 1024; /* physical for i915/i945 */
 }
diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
index d63e71fe469e..af121c720b89 100644
--- a/drivers/gpu/drm/i915/display/intel_sprite.c
+++ b/drivers/gpu/drm/i915/display/intel_sprite.c
@@ -983,7 +983,7 @@ static unsigned int g4x_sprite_min_alignment(struct intel_plane *plane,
 	struct drm_i915_private *i915 = to_i915(plane->base.dev);
 
 	if (intel_scanout_needs_vtd_wa(i915))
-		return 256 * 1024;
+		return 128 * 1024;
 
 	return 4 * 1024;
 }
-- 
2.45.2


  parent reply	other threads:[~2025-01-22 15:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 15:17 [PATCH 0/5] drm/i915: Improve the display VT-d workarounds Ville Syrjala
2025-01-22 15:17 ` [PATCH 1/5] drm/i915: Move VT-d alignment into plane->min_alignment() Ville Syrjala
2025-01-27  9:50   ` Jani Nikula
2025-01-27 16:44     ` Ville Syrjälä
2025-01-27 17:27       ` Ville Syrjälä
2025-01-28  9:46         ` Jani Nikula
2025-01-28 16:56           ` Ville Syrjälä
2025-01-22 15:17 ` Ville Syrjala [this message]
2025-01-22 15:17 ` [PATCH 3/5] drm/i915: Calculate the VT-d guard size in the display code Ville Syrjala
2025-01-22 15:17 ` [PATCH 4/5] drm/i915: Use per-plane VT-d guard numbers Ville Syrjala
2025-01-22 15:17 ` [PATCH 5/5] drm/i915/fbdev: Use fb->normal_view.gtt Ville Syrjala
2025-01-22 15:49 ` ✓ CI.Patch_applied: success for drm/i915: Improve the display VT-d workarounds Patchwork
2025-01-22 15:49 ` ✓ CI.checkpatch: " Patchwork
2025-01-22 15:50 ` ✓ CI.KUnit: " Patchwork
2025-01-22 16:07 ` ✓ CI.Build: " Patchwork
2025-01-22 16:09 ` ✓ CI.Hooks: " Patchwork
2025-01-22 16:10 ` ✗ CI.checksparse: warning " Patchwork
2025-01-22 16:37 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-23  4:16 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-04 11:25 ` [PATCH 0/5] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122151755.6928-3-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox