Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 5/5] drm/i915/fbdev: Use fb->normal_view.gtt
Date: Wed, 22 Jan 2025 17:17:55 +0200	[thread overview]
Message-ID: <20250122151755.6928-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250122151755.6928-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Grab the GTT view for the fbdev fb pinning from
fb->normal_view.gtt instead of having and extra one on
the stack. Seems safer in case we ever put any new
information into normal GTT views.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbdev.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 833cded53d37..301b5fd301a2 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -177,9 +177,6 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	struct intel_framebuffer *fb = ifbdev->fb;
 	struct drm_device *dev = helper->dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	const struct i915_gtt_view view = {
-		.type = I915_GTT_VIEW_NORMAL,
-	};
 	intel_wakeref_t wakeref;
 	struct fb_info *info;
 	struct i915_vma *vma;
@@ -226,7 +223,7 @@ static int intelfb_create(struct drm_fb_helper *helper,
 	 * This also validates that any existing fb inherited from the
 	 * BIOS is suitable for own access.
 	 */
-	vma = intel_fb_pin_to_ggtt(&fb->base, &view,
+	vma = intel_fb_pin_to_ggtt(&fb->base, &fb->normal_view.gtt,
 				   fb->min_alignment, 0,
 				   intel_fb_view_vtd_guard(&fb->base, &fb->normal_view,
 							   DRM_MODE_ROTATE_0),
-- 
2.45.2


  parent reply	other threads:[~2025-01-22 15:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 15:17 [PATCH 0/5] drm/i915: Improve the display VT-d workarounds Ville Syrjala
2025-01-22 15:17 ` [PATCH 1/5] drm/i915: Move VT-d alignment into plane->min_alignment() Ville Syrjala
2025-01-27  9:50   ` Jani Nikula
2025-01-27 16:44     ` Ville Syrjälä
2025-01-27 17:27       ` Ville Syrjälä
2025-01-28  9:46         ` Jani Nikula
2025-01-28 16:56           ` Ville Syrjälä
2025-01-22 15:17 ` [PATCH 2/5] drm/i915: Use more optimal VTd alignment for planes Ville Syrjala
2025-01-22 15:17 ` [PATCH 3/5] drm/i915: Calculate the VT-d guard size in the display code Ville Syrjala
2025-01-22 15:17 ` [PATCH 4/5] drm/i915: Use per-plane VT-d guard numbers Ville Syrjala
2025-01-22 15:17 ` Ville Syrjala [this message]
2025-01-22 15:49 ` ✓ CI.Patch_applied: success for drm/i915: Improve the display VT-d workarounds Patchwork
2025-01-22 15:49 ` ✓ CI.checkpatch: " Patchwork
2025-01-22 15:50 ` ✓ CI.KUnit: " Patchwork
2025-01-22 16:07 ` ✓ CI.Build: " Patchwork
2025-01-22 16:09 ` ✓ CI.Hooks: " Patchwork
2025-01-22 16:10 ` ✗ CI.checksparse: warning " Patchwork
2025-01-22 16:37 ` ✓ Xe.CI.BAT: success " Patchwork
2025-01-23  4:16 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-04 11:25 ` [PATCH 0/5] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122151755.6928-6-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox