Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH 2/3] drm/xe/devcoredump: Temporarily disable the line wrapping of ASCII85 output
Date: Wed, 22 Jan 2025 13:46:00 -0800	[thread overview]
Message-ID: <20250122214601.3560156-3-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20250122214601.3560156-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

Line wrapping is required for doing emergency dumps to dmesg. However,
it currently breaks a mesa debug tool. So temporarily disable the wraps.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 81dc7795c065..18a7ddb561d8 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -462,7 +462,8 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
 		line_pos += strlen(line_buff + line_pos);
 
 		if ((line_pos + MIN_SPACE) >= DMESG_MAX_LINE_LEN) {
-			line_buff[line_pos++] = '\n';
+			/* Line wrapping currently breaks a mesa debug tool. */
+			/* line_buff[line_pos++] = '\n'; */
 			line_buff[line_pos++] = 0;
 
 			drm_puts(p, line_buff);
-- 
2.47.0


  parent reply	other threads:[~2025-01-22 21:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 21:45 [PATCH 0/3] Re-instate GuC logs in debugfs & devcoredump John.C.Harrison
2025-01-22 21:45 ` [PATCH 1/3] drm/xe/guc: Explicitly name each chunk of GuC log data in a dump John.C.Harrison
2025-01-22 21:46 ` John.C.Harrison [this message]
2025-01-22 21:46 ` [PATCH 3/3] Partially revert "drm/xe: Revert some changes that break a mesa debug tool" John.C.Harrison
2025-01-22 21:54 ` ✓ CI.Patch_applied: success for Re-instate GuC logs in debugfs & devcoredump Patchwork
2025-01-22 21:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-22 21:55 ` ✓ CI.KUnit: success " Patchwork
2025-01-22 22:02 ` ✗ CI.Build: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122214601.3560156-3-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox