Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John.C.Harrison@Intel.com
To: Intel-Xe@Lists.FreeDesktop.Org
Cc: John Harrison <John.C.Harrison@Intel.com>
Subject: [PATCH 3/3] Partially revert "drm/xe: Revert some changes that break a mesa debug tool"
Date: Wed, 22 Jan 2025 13:46:01 -0800	[thread overview]
Message-ID: <20250122214601.3560156-4-John.C.Harrison@Intel.com> (raw)
In-Reply-To: <20250122214601.3560156-1-John.C.Harrison@Intel.com>

From: John Harrison <John.C.Harrison@Intel.com>

This reverts part of commit a53da2fb25a31f4fb8eaeb93c7b1134fc14fd209.

The KMD has been updated to avoid the line wrapping issue of the mesa
tool. The section heading issue has not been fixed yet, however. So
that part of the original revert remains.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
---
 drivers/gpu/drm/xe/xe_devcoredump.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c
index 18a7ddb561d8..81a461d62770 100644
--- a/drivers/gpu/drm/xe/xe_devcoredump.c
+++ b/drivers/gpu/drm/xe/xe_devcoredump.c
@@ -420,15 +420,6 @@ void xe_print_blob_ascii85(struct drm_printer *p, const char *prefix,
 	char buff[ASCII85_BUFSZ], *line_buff;
 	size_t line_pos = 0;
 
-	/*
-	 * Splitting blobs across multiple lines is not compatible with the mesa
-	 * debug decoder tool. Note that even dropping the explicit '\n' below
-	 * doesn't help because the GuC log is so big some underlying implementation
-	 * still splits the lines at 512K characters. So just bail completely for
-	 * the moment.
-	 */
-	return;
-
 #define DMESG_MAX_LINE_LEN	800
 #define MIN_SPACE		(ASCII85_BUFSZ + 2)		/* 85 + "\n\0" */
 
-- 
2.47.0


  parent reply	other threads:[~2025-01-22 21:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-22 21:45 [PATCH 0/3] Re-instate GuC logs in debugfs & devcoredump John.C.Harrison
2025-01-22 21:45 ` [PATCH 1/3] drm/xe/guc: Explicitly name each chunk of GuC log data in a dump John.C.Harrison
2025-01-22 21:46 ` [PATCH 2/3] drm/xe/devcoredump: Temporarily disable the line wrapping of ASCII85 output John.C.Harrison
2025-01-22 21:46 ` John.C.Harrison [this message]
2025-01-22 21:54 ` ✓ CI.Patch_applied: success for Re-instate GuC logs in debugfs & devcoredump Patchwork
2025-01-22 21:54 ` ✗ CI.checkpatch: warning " Patchwork
2025-01-22 21:55 ` ✓ CI.KUnit: success " Patchwork
2025-01-22 22:02 ` ✗ CI.Build: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250122214601.3560156-4-John.C.Harrison@Intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@Lists.FreeDesktop.Org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox