From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH] drm/i915: Give i915 and xe each their own display tracepoints
Date: Mon, 27 Jan 2025 23:30:55 +0200 [thread overview]
Message-ID: <20250127213055.640-1-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Currently we just define the display tracpoints with
TRACE_SYSTEM i915. However the code gets included separately
in i915 and xe, and now both modules are competing for the
same tracpoints. Apparently whichever module is loaded first
gets the tracepoints and the other guy is left with nothing.
Give each module its own set of display tracpoints so that
things work even when both modules are loaded.
This one had me stumped for a bit when after a reboot I lost
all i915 display tracpoints (on account of the new kernel
also including xe, and something also ended up loading it
before I manually loaded i915).
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display_trace.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_trace.h b/drivers/gpu/drm/i915/display/intel_display_trace.h
index 54a6e2a46b82..0e10c2856058 100644
--- a/drivers/gpu/drm/i915/display/intel_display_trace.h
+++ b/drivers/gpu/drm/i915/display/intel_display_trace.h
@@ -4,7 +4,11 @@
*/
#undef TRACE_SYSTEM
+#ifdef I915
#define TRACE_SYSTEM i915
+#else
+#define TRACE_SYSTEM xe
+#endif
#if !defined(__INTEL_DISPLAY_TRACE_H__) || defined(TRACE_HEADER_MULTI_READ)
#define __INTEL_DISPLAY_TRACE_H__
--
2.45.3
next reply other threads:[~2025-01-27 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 21:30 Ville Syrjala [this message]
2025-01-27 21:40 ` [PATCH] drm/i915: Give i915 and xe each their own display tracepoints Cavitt, Jonathan
2025-01-28 9:50 ` Jani Nikula
2025-01-28 16:50 ` Ville Syrjälä
2025-01-27 22:22 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-27 22:22 ` ✓ CI.checkpatch: " Patchwork
2025-01-27 22:23 ` ✓ CI.KUnit: " Patchwork
2025-01-27 22:40 ` ✓ CI.Build: " Patchwork
2025-01-27 22:42 ` ✓ CI.Hooks: " Patchwork
2025-01-27 22:43 ` ✓ CI.checksparse: " Patchwork
2025-01-27 23:00 ` [PATCH] " Lucas De Marchi
2025-01-28 16:50 ` Ville Syrjälä
2025-01-27 23:04 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-01-28 11:55 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127213055.640-1-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox