Re: [PATCH] drm/i915: Give i915 and xe each their own display tracepoints

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Jan 27, 2025 at 09:40:12PM +0000, Cavitt, Jonathan wrote:
> -----Original Message-----
> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjala
> Sent: Monday, January 27, 2025 1:31 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: intel-xe@lists.freedesktop.org
> Subject: [PATCH] drm/i915: Give i915 and xe each their own display tracepoints
> > 
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Currently we just define the display tracpoints with
> > TRACE_SYSTEM i915. However the code gets included separately
> > in i915 and xe, and now both modules are competing for the
> > same tracpoints. Apparently whichever module is loaded first
> > gets the tracepoints and the other guy is left with nothing.
> > 
> > Give each module its own set of display tracpoints so that
> > things work even when both modules are loaded.
> > 
> > This one had me stumped for a bit when after a reboot I lost
> > all i915 display tracpoints (on account of the new kernel
> > also including xe, and something also ended up loading it
> > before I manually loaded i915).
> 
> s/tracpoints/tracepoints
> 
> Also, the last sentence in this commit message probably isn't
> necessary, but it doesn't detract from anything, so I won't block
> on its removal.

Yeah, probably doesn't add anything of value. Dropped.

> Just fix the tracepoints spelling and this is:
> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Thanks.

-- 
Ville Syrjälä
Intel