Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "drm/xe/lnl: Enable GuC SLPC DCC task"
@ 2025-01-28 22:32 Rodrigo Vivi
  2025-01-28 22:43 ` Cavitt, Jonathan
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Rodrigo Vivi @ 2025-01-28 22:32 UTC (permalink / raw)
  To: intel-xe; +Cc: Rodrigo Vivi, Vinay Belgaumkar, Jonathan Cavitt

This reverts commit 50554bf3e56dd0c78ef1eedb685d0ab36c9c9987.

DCC in LNL should be disabled. It was a mistake to decide
to go against GuC platform defaults in this case and this
could lead to regressions in some TDP limited scenarios
instead of helping.

Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_pc.c | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
index 44b5211066ef..43f9617baba2 100644
--- a/drivers/gpu/drm/xe/xe_guc_pc.c
+++ b/drivers/gpu/drm/xe/xe_guc_pc.c
@@ -993,27 +993,6 @@ static int pc_init_freqs(struct xe_guc_pc *pc)
 	return ret;
 }
 
-static int slpc_enable_dcc(struct xe_guc_pc *pc)
-{
-	int ret;
-
-	ret = pc_action_set_param(pc, SLPC_PARAM_TASK_ENABLE_DCC, 1);
-	if (ret)
-		return ret;
-
-	return pc_action_set_param(pc, SLPC_PARAM_TASK_DISABLE_DCC, 0);
-}
-
-static int slpc_set_policies(struct xe_guc_pc *pc)
-{
-	struct xe_device *xe = pc_to_xe(pc);
-
-	if (xe->info.platform == XE_LUNARLAKE)
-		return slpc_enable_dcc(pc);
-
-	return 0;
-}
-
 /**
  * xe_guc_pc_start - Start GuC's Power Conservation component
  * @pc: Xe_GuC_PC instance
@@ -1058,10 +1037,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc)
 		goto out;
 	}
 
-	ret = slpc_set_policies(pc);
-	if (ret)
-		goto out;
-
 	ret = pc_init_freqs(pc);
 	if (ret)
 		goto out;
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-01-29 13:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-28 22:32 [PATCH] Revert "drm/xe/lnl: Enable GuC SLPC DCC task" Rodrigo Vivi
2025-01-28 22:43 ` Cavitt, Jonathan
2025-01-28 23:36 ` ✓ CI.Patch_applied: success for " Patchwork
2025-01-28 23:36 ` ✓ CI.checkpatch: " Patchwork
2025-01-28 23:38 ` ✓ CI.KUnit: " Patchwork
2025-01-28 23:54 ` ✓ CI.Build: " Patchwork
2025-01-28 23:56 ` ✗ CI.Hooks: failure " Patchwork
2025-01-28 23:57 ` ✓ CI.checksparse: success " Patchwork
2025-01-29  0:17 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-29 13:45 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox