Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH 1/4] drm/i915/dsb: Allow DSB based updates without planes
Date: Tue, 18 Feb 2025 22:58:47 +0200	[thread overview]
Message-ID: <20250218205850.1422-2-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250218205850.1422-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

We don't actually need any planes to get updated in order
to perform the commit on the DSB. Allow DSB based updates
even when we don't touch planes. The main benefit here
is that pure LUT updates will now go through the DSB path
and therefore we don't have to do vblank evasion/etc. on
the CPU.

I think the reason I had this excluded was that I was
originally contemplating using frame/flip timestamps as
a way to complete the commits. But I had to scrap that
idea when it turned out that those timestamp get
corrupted when DSB is poking at random registers.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 065fdf6dbb88..8d46c092fa4d 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7332,7 +7332,6 @@ static void intel_atomic_dsb_prepare(struct intel_atomic_state *state,
 
 	/* FIXME deal with everything */
 	new_crtc_state->use_dsb =
-		new_crtc_state->update_planes &&
 		!new_crtc_state->do_async_flip &&
 		(DISPLAY_VER(display) >= 20 || !new_crtc_state->has_psr) &&
 		!new_crtc_state->scaler_state.scaler_users &&
-- 
2.45.3


  reply	other threads:[~2025-02-18 20:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 20:58 [PATCH 0/4] drm/i915/dsb: Update plane scalers on DSB Ville Syrjala
2025-02-18 20:58 ` Ville Syrjala [this message]
2025-02-24  5:50   ` [PATCH 1/4] drm/i915/dsb: Allow DSB based updates without planes Shankar, Uma
2025-02-18 20:58 ` [PATCH 2/4] drm/i915/dsb: Plumb dsb into plane scaler functions Ville Syrjala
2025-02-24  5:55   ` Shankar, Uma
2025-02-18 20:58 ` [PATCH 3/4] drm/i915/dsb: Allow DSB based commits when scalers are in use Ville Syrjala
2025-02-24  6:36   ` Shankar, Uma
2025-02-18 20:58 ` [PATCH 4/4] drm/i915: Do state check for color management changes Ville Syrjala
2025-02-18 23:40 ` ✓ CI.Patch_applied: success for drm/i915/dsb: Update plane scalers on DSB Patchwork
2025-02-18 23:40 ` ✓ CI.checkpatch: " Patchwork
2025-02-18 23:41 ` ✓ CI.KUnit: " Patchwork
2025-02-18 23:57 ` ✓ CI.Build: " Patchwork
2025-02-19  0:00 ` ✓ CI.Hooks: " Patchwork
2025-02-19  0:01 ` ✗ CI.checksparse: warning " Patchwork
2025-02-19  7:16 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-20  8:12 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218205850.1422-2-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox