Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, Uma Shankar <uma.shankar@intel.com>
Subject: [PATCH 4/4] drm/i915: Do state check for color management changes
Date: Tue, 18 Feb 2025 22:58:50 +0200	[thread overview]
Message-ID: <20250218205850.1422-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250218205850.1422-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

In order to validate LUT programming more thoroughly let's
do a state check for all color management updates as well.

Not sure we really want this outside CI. It is rather heavy
and color management updates could become rather common
with all the HDR/etc. stuff happening. Maybe we should have
an extra knob for this that we could enable in CI?

v2: Skip for initial_commit to avoid FDI dotclock
    sanity checks/etc. tripping up

Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_modeset_verify.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_modeset_verify.c b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
index bc70e72ccc2e..f61641d27c4a 100644
--- a/drivers/gpu/drm/i915/display/intel_modeset_verify.c
+++ b/drivers/gpu/drm/i915/display/intel_modeset_verify.c
@@ -239,6 +239,8 @@ void intel_modeset_verify_crtc(struct intel_atomic_state *state,
 		intel_atomic_get_new_crtc_state(state, crtc);
 
 	if (!intel_crtc_needs_modeset(new_crtc_state) &&
+	    (!intel_crtc_needs_color_update(new_crtc_state) ||
+	     new_crtc_state->inherited) &&
 	    !intel_crtc_needs_fastset(new_crtc_state))
 		return;
 
-- 
2.45.3


  parent reply	other threads:[~2025-02-18 20:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 20:58 [PATCH 0/4] drm/i915/dsb: Update plane scalers on DSB Ville Syrjala
2025-02-18 20:58 ` [PATCH 1/4] drm/i915/dsb: Allow DSB based updates without planes Ville Syrjala
2025-02-24  5:50   ` Shankar, Uma
2025-02-18 20:58 ` [PATCH 2/4] drm/i915/dsb: Plumb dsb into plane scaler functions Ville Syrjala
2025-02-24  5:55   ` Shankar, Uma
2025-02-18 20:58 ` [PATCH 3/4] drm/i915/dsb: Allow DSB based commits when scalers are in use Ville Syrjala
2025-02-24  6:36   ` Shankar, Uma
2025-02-18 20:58 ` Ville Syrjala [this message]
2025-02-18 23:40 ` ✓ CI.Patch_applied: success for drm/i915/dsb: Update plane scalers on DSB Patchwork
2025-02-18 23:40 ` ✓ CI.checkpatch: " Patchwork
2025-02-18 23:41 ` ✓ CI.KUnit: " Patchwork
2025-02-18 23:57 ` ✓ CI.Build: " Patchwork
2025-02-19  0:00 ` ✓ CI.Hooks: " Patchwork
2025-02-19  0:01 ` ✗ CI.checksparse: warning " Patchwork
2025-02-19  7:16 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-20  8:12 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218205850.1422-5-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox