Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org, vinod.govindapillai@intel.com,
	ville.syrjala@linux.intel.com, santhosh.reddy.guddati@intel.com,
	jani.saarinen@intel.com
Subject: [PATCH v9 7/8] drm/i915/fbc: disable FBC if PSR2 selective fetch is enabled
Date: Thu, 20 Feb 2025 12:41:43 +0200	[thread overview]
Message-ID: <20250220104144.207526-8-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20250220104144.207526-1-vinod.govindapillai@intel.com>

It is not recommended to have both FBC dirty rect and PSR2
selective fetch be enabled at the same time. Mark FBC as not
possible, if PSR2 selective fetch is enabled.

v2: fix the condition to disable FBC if PSR2 enabled (Jani)

v3: use HAS_FBC_DIRTY_RECT()

v4: Update to patch description

Bspec: 68881
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/i915/display/intel_fbc.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
index 01d4540424b5..6222eea4b1ce 100644
--- a/drivers/gpu/drm/i915/display/intel_fbc.c
+++ b/drivers/gpu/drm/i915/display/intel_fbc.c
@@ -1433,9 +1433,14 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
 	 * Display 12+ is not supporting FBC with PSR2.
 	 * Recommendation is to keep this combination disabled
 	 * Bspec: 50422 HSD: 14010260002
+	 *
+	 * In Xe3, PSR2 selective fetch and FBC dirty rect feature cannot
+	 * coexist. So if PSR2 selective fetch is supported then mark that
+	 * FBC is not supported.
+	 * TODO: Need a logic to decide between PSR2 and FBC Dirty rect
 	 */
-	if (IS_DISPLAY_VER(display, 12, 14) && crtc_state->has_sel_update &&
-	    !crtc_state->has_panel_replay) {
+	if ((IS_DISPLAY_VER(display, 12, 14) || HAS_FBC_DIRTY_RECT(display)) &&
+	    crtc_state->has_sel_update && !crtc_state->has_panel_replay) {
 		plane_state->no_fbc_reason = "PSR2 enabled";
 		return 0;
 	}
-- 
2.43.0


  parent reply	other threads:[~2025-02-20 10:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 10:41 [PATCH v9 0/8] drm/i915/fbc: FBC Dirty rect feature support Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 1/8] drm/damage-helper: add const qualifier in drm_atomic_helper_damage_merged() Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 2/8] drm/i915/display: update and store the plane damage clips Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 3/8] drm/i915/fbc: add register definitions for fbc dirty rect support Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 4/8] drm/i915/fbc: introduce HAS_FBC_DIRTY_RECT() for FBC " Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 5/8] drm/i915/fbc: avoid calling fbc activate if fbc is active Vinod Govindapillai
2025-02-20 10:41 ` [PATCH v9 6/8] drm/i915/fbc: dirty rect support for FBC Vinod Govindapillai
2025-02-20 10:41 ` Vinod Govindapillai [this message]
2025-02-20 10:41 ` [PATCH v9 8/8] drm/i915/fbc: handle dirty rect coords for the first frame Vinod Govindapillai
2025-02-21 17:54   ` Ville Syrjälä
2025-02-20 10:47 ` ✓ CI.Patch_applied: success for drm/i915/fbc: FBC Dirty rect feature support (rev3) Patchwork
2025-02-20 10:47 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-20 10:49 ` ✓ CI.KUnit: success " Patchwork
2025-02-20 11:05 ` ✓ CI.Build: " Patchwork
2025-02-20 11:07 ` ✓ CI.Hooks: " Patchwork
2025-02-20 11:09 ` ✗ CI.checksparse: warning " Patchwork
2025-02-20 11:29 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-21  5:13 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-21  7:45   ` Govindapillai, Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220104144.207526-8-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.saarinen@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox