From: Jonathan Cavitt <jonathan.cavitt@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: saurabhg.gupta@intel.com, alex.zuo@intel.com,
jonathan.cavitt@intel.com, joonas.lahtinen@linux.intel.com,
tvrtko.ursulin@igalia.com, lucas.demarchi@intel.com,
matthew.brost@intel.com, dri-devel@lists.freedesktop.org,
simona.vetter@ffwll.ch
Subject: [PATCH v4 0/6] drm/xe/xe_drm_client: Add per drm client reset stats
Date: Thu, 20 Feb 2025 20:38:26 +0000 [thread overview]
Message-ID: <20250220203832.130430-1-jonathan.cavitt@intel.com> (raw)
Add additional information to drm client so it can report the last 50
exec queues to have been banned on it, as well as the last pagefault
seen when said exec queues were banned. Since we cannot reasonably
associate a pagefault to a specific exec queue, we currently report the
last seen pagefault on the associated hw engine instead.
The last pagefault seen per exec queue is saved to the hw engine, and the
pagefault is updated during the pagefault handling process in
xe_gt_pagefault. The last seen pagefault is reset when the engine is
reset because any future exec queue bans likely were not caused by said
pagefault after the reset.
Also add a tracker that counts the number of times the drm client has
experienced an engine reset.
Finally, add a new query to xe_query that reports these drm client reset
stats back to the user.
v2: Report the per drm client reset stats as a query, rather than
coopting xe_drm_client_fdinfo (Joonas)
v3: Report EOPNOTSUPP during the reset stats query if CONFIG_PROC_FS
is not set in the kernel config, as it is required to trace the
reset count and exec queue bans.
v4: Fix formatting and kzalloc during lock warnings
Test-with: 20250220203747.130371-1-jonathan.cavitt@intel.com
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
CC: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
CC: Lucas de Marchi <lucas.demarchi@intel.com>
CC: Matthew Brost <matthew.brost@intel.com>
CC: Simona Vetter <simona.vetter@ffwll.ch>
Jonathan Cavitt (6):
drm/xe/xe_exec_queue: Add ID param to exec queue struct
drm/xe/xe_gt_pagefault: Migrate pagefault struct to header
drm/xe/xe_drm_client: Add per drm client pagefault info
drm/xe/xe_drm_client: Add per drm client reset stats
drm/xe/xe_query: Pass drm file to query funcs
drm/xe/xe_query: Add support for per-drm-client reset stat querying
drivers/gpu/drm/xe/xe_drm_client.c | 68 ++++++++++++++
drivers/gpu/drm/xe/xe_drm_client.h | 44 +++++++++
drivers/gpu/drm/xe/xe_exec_queue.c | 8 ++
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 +
drivers/gpu/drm/xe/xe_gt_pagefault.c | 44 ++++-----
drivers/gpu/drm/xe/xe_gt_pagefault.h | 28 ++++++
drivers/gpu/drm/xe/xe_guc_submit.c | 17 ++++
drivers/gpu/drm/xe/xe_hw_engine.c | 4 +
drivers/gpu/drm/xe/xe_hw_engine_types.h | 8 ++
drivers/gpu/drm/xe/xe_query.c | 109 ++++++++++++++++++++---
include/uapi/drm/xe_drm.h | 50 +++++++++++
11 files changed, 343 insertions(+), 39 deletions(-)
--
2.43.0
next reply other threads:[~2025-02-20 20:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 20:38 Jonathan Cavitt [this message]
2025-02-20 20:38 ` [PATCH v4 1/6] drm/xe/xe_exec_queue: Add ID param to exec queue struct Jonathan Cavitt
2025-02-25 21:12 ` Matthew Brost
2025-02-20 20:38 ` [PATCH v4 2/6] drm/xe/xe_gt_pagefault: Migrate pagefault struct to header Jonathan Cavitt
2025-02-25 20:48 ` Matthew Brost
2025-02-20 20:38 ` [PATCH v4 3/6] drm/xe/xe_drm_client: Add per drm client pagefault info Jonathan Cavitt
2025-02-25 21:10 ` Matthew Brost
2025-02-20 20:38 ` [PATCH v4 4/6] drm/xe/xe_drm_client: Add per drm client reset stats Jonathan Cavitt
2025-02-25 21:11 ` Matthew Brost
2025-02-20 20:38 ` [PATCH v4 5/6] drm/xe/xe_query: Pass drm file to query funcs Jonathan Cavitt
2025-02-20 20:38 ` [PATCH v4 6/6] drm/xe/xe_query: Add support for per-drm-client reset stat querying Jonathan Cavitt
2025-02-25 21:31 ` Matthew Brost
2025-02-25 23:18 ` Matthew Brost
2025-02-20 20:43 ` ✓ CI.Patch_applied: success for drm/xe/xe_drm_client: Add per drm client reset stats (rev5) Patchwork
2025-02-20 20:43 ` ✓ CI.checkpatch: " Patchwork
2025-02-20 20:45 ` ✓ CI.KUnit: " Patchwork
2025-02-20 21:01 ` ✓ CI.Build: " Patchwork
2025-02-20 21:04 ` ✓ CI.Hooks: " Patchwork
2025-02-20 21:05 ` ✓ CI.checksparse: " Patchwork
2025-02-20 21:38 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-02-21 15:41 ` ✗ Xe.CI.Full: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-02-19 20:28 [PATCH v4 0/6] drm/xe/xe_drm_client: Add per drm client reset stats Jonathan Cavitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220203832.130430-1-jonathan.cavitt@intel.com \
--to=jonathan.cavitt@intel.com \
--cc=alex.zuo@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=lucas.demarchi@intel.com \
--cc=matthew.brost@intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=tvrtko.ursulin@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox