Re: [PATCH v4 1/6] drm/xe/xe_exec_queue: Add ID param to exec queue struct

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Feb 20, 2025 at 08:38:27PM +0000, Jonathan Cavitt wrote:
> Add the exec queue id to the exec queue struct.  This is useful for
> performing a reverse lookup into the xef->exec_queue xarray.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Have quite a few comments on the series, assuming this is needed after
those are addressed:

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c       | 1 +
>  drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 23a9f519ce1c..4a98a5d0e405 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -709,6 +709,7 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data,
>  	if (err)
>  		goto kill_exec_queue;
>  
> +	q->id = id;
>  	args->exec_queue_id = id;
>  
>  	return 0;
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue_types.h b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> index 6eb7ff091534..088d838218e9 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue_types.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue_types.h
> @@ -55,6 +55,8 @@ struct xe_exec_queue {
>  	struct xe_vm *vm;
>  	/** @class: class of this exec queue */
>  	enum xe_engine_class class;
> +	/** @id: exec queue ID as reported during create ioctl */
> +	u32 id;
>  	/**
>  	 * @logical_mask: logical mask of where job submitted to exec queue can run
>  	 */
> -- 
> 2.43.0
>