Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/3] drm/xe: Fix survivability
@ 2025-03-13 20:40 Lucas De Marchi
  2025-03-13 20:40 ` [PATCH v4 1/3] drm/xe: Move survivability back to xe Lucas De Marchi
                   ` (18 more replies)
  0 siblings, 19 replies; 21+ messages in thread
From: Lucas De Marchi @ 2025-03-13 20:40 UTC (permalink / raw)
  To: intel-xe; +Cc: Lucas De Marchi, Francois Dugast, Riana Tauro, Rodrigo Vivi

It turns out commit d40f275d96e8 ("drm/xe: Move survivability entirely
to xe_pci") did a bad job moving things to xe_pci. The fix provided by
Riana in 20250306055407.511405-1-riana.tauro@intel.com fixes it
partially, but injecting a failure in xe_pcode_probe_early still causes
the kernel to give warnings/errors.

Correct the course and better split what is done in xe_pci vs xe_device.
This time, also add a patch to test we can handle errors in
xe_pcode_probe_early() and other early probe functions.

Entering survivability mode was tested with an additional one line to
change the return of xe_survivability_mode_requested(). If we want to
inject error, we'd need to change it's return type, but there's also
another patch series to force it via configs, so this doesn't seem very
important right now.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
Changes in v4:
- Minor change in 1st patch, no change in behavior
- Link to v3: https://lore.kernel.org/r/20250312-fix-survivability-v3-0-54620dbcbbd7@intel.com

Changes in v3:
- Add another fix for heci
- Rename function according to review feedback
- Link to v2: https://lore.kernel.org/r/20250311-fix-survivability-v2-0-729ce081155e@intel.com

Changes in v2:
- Cover more error injections in the second patch
- Link to v1: https://lore.kernel.org/r/20250310-fix-survivability-v1-0-7af31432bbd0@intel.com

---
Lucas De Marchi (3):
      drm/xe: Move survivability back to xe
      drm/xe: Set survivability mode before heci init
      drm/xe: Allow to inject error in early probe

 drivers/gpu/drm/xe/xe_device.c             | 18 ++++++++++++++++--
 drivers/gpu/drm/xe/xe_mmio.c               |  1 +
 drivers/gpu/drm/xe/xe_pci.c                | 16 +++++++---------
 drivers/gpu/drm/xe/xe_pcode.c              |  2 ++
 drivers/gpu/drm/xe/xe_survivability_mode.c | 29 +++++++++++++++++++++--------
 drivers/gpu/drm/xe/xe_survivability_mode.h |  1 -
 6 files changed, 47 insertions(+), 20 deletions(-)
---
base-commit: 7e32e5705a5c8398e606a23eeba751a059a0b970
change-id: 20250310-fix-survivability-703246c0c480

Best regards,
-- 
Lucas De Marchi <lucas.demarchi@intel.com>


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2025-03-18 15:51 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 20:40 [PATCH v4 0/3] drm/xe: Fix survivability Lucas De Marchi
2025-03-13 20:40 ` [PATCH v4 1/3] drm/xe: Move survivability back to xe Lucas De Marchi
2025-03-17  5:24   ` Riana Tauro
2025-03-13 20:41 ` [PATCH v4 2/3] drm/xe: Set survivability mode before heci init Lucas De Marchi
2025-03-13 20:41 ` [PATCH v4 3/3] drm/xe: Allow to inject error in early probe Lucas De Marchi
2025-03-13 20:48 ` ✓ CI.Patch_applied: success for drm/xe: Fix survivability (rev4) Patchwork
2025-03-13 20:48 ` ✓ CI.checkpatch: " Patchwork
2025-03-13 20:49 ` ✓ CI.KUnit: " Patchwork
2025-03-13 21:06 ` ✓ CI.Build: " Patchwork
2025-03-13 21:08 ` ✓ CI.Hooks: " Patchwork
2025-03-13 21:10 ` ✓ CI.checksparse: " Patchwork
2025-03-14 12:07 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-14 12:47 ` ✓ CI.Patch_applied: success for drm/xe: Fix survivability (rev6) Patchwork
2025-03-14 12:48 ` ✓ CI.checkpatch: " Patchwork
2025-03-14 12:49 ` ✓ CI.KUnit: " Patchwork
2025-03-14 13:19 ` ✓ CI.Build: " Patchwork
2025-03-14 13:21 ` ✓ CI.Hooks: " Patchwork
2025-03-14 13:23 ` ✓ CI.checksparse: " Patchwork
2025-03-14 13:44 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-14 20:45 ` ✓ Xe.CI.Full: " Patchwork
2025-03-18 15:50 ` [PATCH v4 0/3] drm/xe: Fix survivability Raag Jadav

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox