From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
ville.syrjala@linux.intel.com,
mitulkumar.ajitkumar.golani@intel.com
Subject: [PATCH 02/16] drm/i915/vrr: Avoid reading vrr.enable based on fixed_rr check
Date: Tue, 18 Mar 2025 13:05:26 +0530 [thread overview]
Message-ID: <20250318073540.2773890-3-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250318073540.2773890-1-ankit.k.nautiyal@intel.com>
Currently, vrr.enable is intended only for variable refresh rate timings.
At this point, we do not set fixed refresh rate timings, but the GOP can,
which creates a problem during the readback of vrr.enable.
The GOP enables the VRR timing generator with fixed timings, while the
driver only recognizes the VRR timing generator as enabled with
variable timings. This discrepancy causes an issue due to the
fixed refresh rate check during readback. Since the VRR timing generator
is enabled and we do not support fixed timings, the readback should set
vrr.enable so that the driver can disable the VRR timing generator.
However, the current check does not allow this.
Therefore, remove the fixed refresh rate check during readback.
Fixes: 27217f9d1856 ("drm/i915/vrr: Track vrr.enable only for variable timing")
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index aa65a6933ddb..6bdcdfed4b9b 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -657,8 +657,7 @@ void intel_vrr_get_config(struct intel_crtc_state *crtc_state)
}
}
- crtc_state->vrr.enable = trans_vrr_ctl & VRR_CTL_VRR_ENABLE &&
- !intel_vrr_is_fixed_rr(crtc_state);
+ crtc_state->vrr.enable = trans_vrr_ctl & VRR_CTL_VRR_ENABLE;
/*
* #TODO: For Both VRR and CMRR the flag I915_MODE_FLAG_VRR is set for mode_flags.
--
2.45.2
next prev parent reply other threads:[~2025-03-18 7:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 7:35 [PATCH 00/16] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 01/16] drm/i915/display: Add fixed_rr to crtc_state dump Ankit Nautiyal
2025-03-18 7:35 ` Ankit Nautiyal [this message]
2025-03-21 17:34 ` [PATCH 02/16] drm/i915/vrr: Avoid reading vrr.enable based on fixed_rr check Ville Syrjälä
2025-03-21 17:40 ` Nautiyal, Ankit K
2025-03-21 17:45 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 03/16] drm/i915/hdmi: Use VRR Timing generator for HDMI for fixed_rr Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 04/16] drm/i915/dp_mst: Use VRR Timing generator for DP MST " Ankit Nautiyal
2025-03-21 17:42 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 05/16] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 06/16] drm/i915/display: Move intel_psr_post_plane_update() at the later Ankit Nautiyal
2025-03-21 17:43 ` Ville Syrjälä
2025-03-24 6:37 ` Hogander, Jouni
2025-03-18 7:35 ` [PATCH 07/16] drm/i915/vrr: Refactor condition for computing vmax and LRR Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 08/16] drm/i915/vrr: Always set vrr vmax/vmin/flipline in vrr_{enable/disable} Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 09/16] drm/i915/vrr: Set vrr.enable for VRR TG with fixed_rr Ankit Nautiyal
2025-03-21 17:44 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 10/16] drm/i915/display: Use fixed_rr timings in modeset sequence Ankit Nautiyal
2025-03-19 14:36 ` Ville Syrjälä
2025-03-20 5:39 ` Nautiyal, Ankit K
2025-03-24 12:10 ` Nautiyal, Ankit K
2025-03-20 4:20 ` Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 11/16] drm/i915/vrr: Use fixed timings for platforms that support VRR Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 12/16] drm/i915/display: Use fixed rr timings in intel_set_transcoder_timings_lrr() Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 13/16] drm/i915/display: Move vrr.guardband/pipeline_full out of !fastset block Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 14/16] drm/i915/vrr: Allow fixed_rr with pipe joiner Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 15/16] drm/i915/vrr: Always use VRR timing generator for PTL+ Ankit Nautiyal
2025-03-21 17:47 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 16/16] drm/i915/vrr: Set trans_vrr_ctl in intel_vrr_set_transcoder_timings() Ankit Nautiyal
2025-03-18 7:57 ` ✗ CI.Patch_applied: failure for Use VRR timing generator for fixed refresh rate modes (rev9) Patchwork
2025-03-20 5:37 ` ✓ CI.Patch_applied: success for Use VRR timing generator for fixed refresh rate modes (rev10) Patchwork
2025-03-20 5:37 ` ✓ CI.checkpatch: " Patchwork
2025-03-20 5:38 ` ✓ CI.KUnit: " Patchwork
2025-03-20 5:55 ` ✓ CI.Build: " Patchwork
2025-03-20 5:57 ` ✓ CI.Hooks: " Patchwork
2025-03-20 5:58 ` ✗ CI.checksparse: warning " Patchwork
2025-03-20 6:18 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-20 7:17 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318073540.2773890-3-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox