From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org, jani.nikula@linux.intel.com,
ville.syrjala@linux.intel.com,
mitulkumar.ajitkumar.golani@intel.com
Subject: [PATCH 08/16] drm/i915/vrr: Always set vrr vmax/vmin/flipline in vrr_{enable/disable}
Date: Tue, 18 Mar 2025 13:05:32 +0530 [thread overview]
Message-ID: <20250318073540.2773890-9-ankit.k.nautiyal@intel.com> (raw)
In-Reply-To: <20250318073540.2773890-1-ankit.k.nautiyal@intel.com>
For platforms for which vrr timing generator is always set, VRR_CTL
enable bit does not need to toggle, so modify the vrr_{enable/disable}
for this.
At the moment the helper intel_vrr_always_use_vrr_tg() return false for
all cases. This will be set later when all other bits are in place.
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_vrr.c | 40 ++++++++++++++++--------
1 file changed, 27 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 34c02d66167e..3f610e382883 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -558,6 +558,16 @@ bool intel_vrr_is_push_sent(const struct intel_crtc_state *crtc_state)
return intel_de_read(display, TRANS_PUSH(display, cpu_transcoder)) & TRANS_PUSH_SEND;
}
+static
+bool intel_vrr_always_use_vrr_tg(struct intel_display *display)
+{
+ if (!HAS_VRR(display))
+ return false;
+
+ /* #TODO return true for platforms supporting fixed_rr */
+ return false;
+}
+
void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
{
struct intel_display *display = to_intel_display(crtc_state);
@@ -576,13 +586,15 @@ void intel_vrr_enable(const struct intel_crtc_state *crtc_state)
intel_de_write(display, TRANS_PUSH(display, cpu_transcoder),
TRANS_PUSH_EN);
- if (crtc_state->cmrr.enable) {
- intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
- VRR_CTL_VRR_ENABLE | VRR_CTL_CMRR_ENABLE |
- trans_vrr_ctl(crtc_state));
- } else {
- intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
- VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state));
+ if (!intel_vrr_always_use_vrr_tg(display)) {
+ if (crtc_state->cmrr.enable) {
+ intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
+ VRR_CTL_VRR_ENABLE | VRR_CTL_CMRR_ENABLE |
+ trans_vrr_ctl(crtc_state));
+ } else {
+ intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
+ VRR_CTL_VRR_ENABLE | trans_vrr_ctl(crtc_state));
+ }
}
}
@@ -594,12 +606,14 @@ void intel_vrr_disable(const struct intel_crtc_state *old_crtc_state)
if (!old_crtc_state->vrr.enable)
return;
- intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
- trans_vrr_ctl(old_crtc_state));
- intel_de_wait_for_clear(display,
- TRANS_VRR_STATUS(display, cpu_transcoder),
- VRR_STATUS_VRR_EN_LIVE, 1000);
- intel_de_write(display, TRANS_PUSH(display, cpu_transcoder), 0);
+ if (!intel_vrr_always_use_vrr_tg(display)) {
+ intel_de_write(display, TRANS_VRR_CTL(display, cpu_transcoder),
+ trans_vrr_ctl(old_crtc_state));
+ intel_de_wait_for_clear(display,
+ TRANS_VRR_STATUS(display, cpu_transcoder),
+ VRR_STATUS_VRR_EN_LIVE, 1000);
+ intel_de_write(display, TRANS_PUSH(display, cpu_transcoder), 0);
+ }
intel_vrr_set_fixed_rr_timings(old_crtc_state);
}
--
2.45.2
next prev parent reply other threads:[~2025-03-18 7:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 7:35 [PATCH 00/16] Use VRR timing generator for fixed refresh rate modes Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 01/16] drm/i915/display: Add fixed_rr to crtc_state dump Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 02/16] drm/i915/vrr: Avoid reading vrr.enable based on fixed_rr check Ankit Nautiyal
2025-03-21 17:34 ` Ville Syrjälä
2025-03-21 17:40 ` Nautiyal, Ankit K
2025-03-21 17:45 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 03/16] drm/i915/hdmi: Use VRR Timing generator for HDMI for fixed_rr Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 04/16] drm/i915/dp_mst: Use VRR Timing generator for DP MST " Ankit Nautiyal
2025-03-21 17:42 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 05/16] drm/i915/display: Disable PSR before disabling VRR Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 06/16] drm/i915/display: Move intel_psr_post_plane_update() at the later Ankit Nautiyal
2025-03-21 17:43 ` Ville Syrjälä
2025-03-24 6:37 ` Hogander, Jouni
2025-03-18 7:35 ` [PATCH 07/16] drm/i915/vrr: Refactor condition for computing vmax and LRR Ankit Nautiyal
2025-03-18 7:35 ` Ankit Nautiyal [this message]
2025-03-18 7:35 ` [PATCH 09/16] drm/i915/vrr: Set vrr.enable for VRR TG with fixed_rr Ankit Nautiyal
2025-03-21 17:44 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 10/16] drm/i915/display: Use fixed_rr timings in modeset sequence Ankit Nautiyal
2025-03-19 14:36 ` Ville Syrjälä
2025-03-20 5:39 ` Nautiyal, Ankit K
2025-03-24 12:10 ` Nautiyal, Ankit K
2025-03-20 4:20 ` Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 11/16] drm/i915/vrr: Use fixed timings for platforms that support VRR Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 12/16] drm/i915/display: Use fixed rr timings in intel_set_transcoder_timings_lrr() Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 13/16] drm/i915/display: Move vrr.guardband/pipeline_full out of !fastset block Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 14/16] drm/i915/vrr: Allow fixed_rr with pipe joiner Ankit Nautiyal
2025-03-18 7:35 ` [PATCH 15/16] drm/i915/vrr: Always use VRR timing generator for PTL+ Ankit Nautiyal
2025-03-21 17:47 ` Ville Syrjälä
2025-03-18 7:35 ` [PATCH 16/16] drm/i915/vrr: Set trans_vrr_ctl in intel_vrr_set_transcoder_timings() Ankit Nautiyal
2025-03-18 7:57 ` ✗ CI.Patch_applied: failure for Use VRR timing generator for fixed refresh rate modes (rev9) Patchwork
2025-03-20 5:37 ` ✓ CI.Patch_applied: success for Use VRR timing generator for fixed refresh rate modes (rev10) Patchwork
2025-03-20 5:37 ` ✓ CI.checkpatch: " Patchwork
2025-03-20 5:38 ` ✓ CI.KUnit: " Patchwork
2025-03-20 5:55 ` ✓ CI.Build: " Patchwork
2025-03-20 5:57 ` ✓ CI.Hooks: " Patchwork
2025-03-20 5:58 ` ✗ CI.checksparse: warning " Patchwork
2025-03-20 6:18 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-20 7:17 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318073540.2773890-9-ankit.k.nautiyal@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mitulkumar.ajitkumar.golani@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox