Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Badal Nilawar <badal.nilawar@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: anshuman.gupta@intel.com, rodrigo.vivi@intel.com,
	rafael.j.wysocki@intel.com, raag.jadav@intel.com
Subject: [PATCH] drm/xe/d3cold: Set power state to D3Cold during s2idle/s3
Date: Thu, 27 Mar 2025 21:49:14 +0530	[thread overview]
Message-ID: <20250327161914.432552-1-badal.nilawar@intel.com> (raw)

According to pci core guidelines, pci_save_config is recommended when the
driver explicitly needs to set the pci power state. As of now xe kmd is
only doing pci_save_config while entering to s2idle/s3 state, which makes
pci core think that device driver has already applied required pci power
state. This leads to GPU remain in D0 state. To fix the issue setting
the pci power state to D3Cold.

Fixes:dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 7046e7e9a6c7..3317d475be79 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -932,6 +932,7 @@ static int xe_pci_suspend(struct device *dev)
 
 	pci_save_state(pdev);
 	pci_disable_device(pdev);
+	pci_set_power_state(pdev, PCI_D3cold);
 
 	return 0;
 }
-- 
2.34.1


             reply	other threads:[~2025-03-27 16:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-27 16:19 Badal Nilawar [this message]
2025-03-27 16:24 ` ✓ CI.Patch_applied: success for drm/xe/d3cold: Set power state to D3Cold during s2idle/s3 Patchwork
2025-03-27 16:25 ` ✗ CI.checkpatch: warning " Patchwork
2025-03-27 16:26 ` ✓ CI.KUnit: success " Patchwork
2025-03-27 16:32 ` [PATCH] " Nilawar, Badal
2025-03-27 17:14   ` Rodrigo Vivi
2025-03-28 16:02     ` Rodrigo Vivi
2025-03-29  5:20       ` Raag Jadav
2025-03-31 16:15         ` Rodrigo Vivi
2025-03-31 20:18           ` Wysocki, Rafael J
2025-04-01 17:53             ` Raag Jadav
2025-04-01 19:35               ` Rafael J. Wysocki
2025-04-02  7:31                 ` Raag Jadav
2025-04-02  8:34                   ` Raag Jadav
2025-04-02 10:31                     ` Rafael J. Wysocki
2025-04-03  3:12                       ` Raag Jadav
2025-04-03 11:12                         ` Rafael J. Wysocki
2025-04-02 10:19                   ` Rafael J. Wysocki
2025-04-02 11:19                 ` Gupta, Anshuman
2025-04-03  7:36                 ` Nilawar, Badal
2025-04-03 11:16                   ` Rafael J. Wysocki
2025-03-27 16:42 ` ✓ CI.Build: success for " Patchwork
2025-03-27 16:44 ` ✓ CI.Hooks: " Patchwork
2025-03-27 16:46 ` ✓ CI.checksparse: " Patchwork
2025-03-27 17:08 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-28  1:49 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250327161914.432552-1-badal.nilawar@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=raag.jadav@intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox