Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe/vf: Fail migration recovery if fixups needed but platform not supported
@ 2025-05-12 23:06 Tomasz Lis
  2025-05-12 23:12 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (16 more replies)
  0 siblings, 17 replies; 19+ messages in thread
From: Tomasz Lis @ 2025-05-12 23:06 UTC (permalink / raw)
  To: intel-xe
  Cc: Michał Winiarski, Michał Wajdeczko,
	Piotr Piórkowski, Satyanarayana K V P

The post-migration recovery needs to be fully implemented for a
specific platform in order to make continuation of workloads
possible.

New platforms introduce changes which affect the recovery procedure,
and without a clear verification of support this leads to errors
with no straight forward error message explaining the cause.

This patch fixes that issue - it introduces a message to be logged
when the current driver is known to not support the current platform.

Wedging the driver immediately also decreases the amount of
additional errors which would come afterwards if the driver continued
operation.

Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
---
 drivers/gpu/drm/xe/xe_sriov_vf.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
index 2674fa948fda..f21f98f5d25f 100644
--- a/drivers/gpu/drm/xe/xe_sriov_vf.c
+++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
@@ -224,6 +224,11 @@ static void vf_post_migration_notify_resfix_done(struct xe_device *xe)
 	drm_dbg(&xe->drm, "another recovery imminent, skipping notifications\n");
 }
 
+static bool fixups_supported(struct xe_device *xe)
+{
+	return false;
+}
+
 static void vf_post_migration_recovery(struct xe_device *xe)
 {
 	bool need_fixups;
@@ -243,6 +248,11 @@ static void vf_post_migration_recovery(struct xe_device *xe)
 		vf_post_migration_fixup_ctb(xe);
 
 	vf_post_migration_notify_resfix_done(xe);
+	if (need_fixups && !fixups_supported(xe)) {
+		drm_err(&xe->drm, "migration recovery not supported by this module version\n");
+		err = -ENOTRECOVERABLE;
+		goto fail;
+	}
 	xe_pm_runtime_put(xe);
 	drm_notice(&xe->drm, "migration recovery ended\n");
 	return;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread
end of thread, other threads:[~2025-05-14  8:01 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-12 23:06 [PATCH v1] drm/xe/vf: Fail migration recovery if fixups needed but platform not supported Tomasz Lis
2025-05-12 23:12 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-12 23:12 ` ✓ CI.checkpatch: " Patchwork
2025-05-12 23:13 ` ✓ CI.KUnit: " Patchwork
2025-05-12 23:23 ` ✗ CI.Build: failure " Patchwork
2025-05-13 11:21 ` [PATCH v1] " Michal Wajdeczko
2025-05-13 23:16   ` Lis, Tomasz
2025-05-13 14:40 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-13 14:40 ` ✓ CI.checkpatch: " Patchwork
2025-05-13 14:42 ` ✓ CI.KUnit: " Patchwork
2025-05-13 14:52 ` ✓ CI.Build: " Patchwork
2025-05-14  5:28 ` ✓ CI.Patch_applied: success for drm/xe/vf: Fail migration recovery if fixups needed but platform not supported (rev2) Patchwork
2025-05-14  5:28 ` ✓ CI.checkpatch: " Patchwork
2025-05-14  5:30 ` ✓ CI.KUnit: " Patchwork
2025-05-14  5:40 ` ✓ CI.Build: " Patchwork
2025-05-14  5:42 ` ✓ CI.Hooks: " Patchwork
2025-05-14  5:44 ` ✓ CI.checksparse: " Patchwork
2025-05-14  6:07 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-14  8:01 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox