From: "André Almeida" <andrealmeid@igalia.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
siqueira@igalia.com, airlied@gmail.com, simona@ffwll.ch,
"Raag Jadav" <raag.jadav@intel.com>,
rodrigo.vivi@intel.com, jani.nikula@linux.intel.com,
"Xaver Hugl" <xaver.hugl@gmail.com>,
"Krzysztof Karas" <krzysztof.karas@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com, amd-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
"André Almeida" <andrealmeid@igalia.com>
Subject: [PATCH v5 0/3] drm: Create a tas info option for wedge events
Date: Tue, 20 May 2025 13:32:40 -0300 [thread overview]
Message-ID: <20250520163243.328746-1-andrealmeid@igalia.com> (raw)
This patchset implements a request made by Xaver Hugl about wedge events:
"I'd really like to have the PID of the client that triggered the GPU
reset, so that we can kill it if multiple resets are triggered in a
row (or switch to software rendering if it's KWin itself) and show a
user-friendly notification about why their app(s) crashed, but that
can be added later."
From https://lore.kernel.org/dri-devel/CAFZQkGwJ4qgHV8WTp2=svJ_VXhb-+Y8_VNtKB=jLsk6DqMYp9w@mail.gmail.com/
For testing, I've used amdgpu's debug_mask options debug_disable_soft_recovery
and debug_disable_gpu_ring_reset to test both wedge event paths in the driver.
To trigger a ring timeout, I've used this app:
https://gitlab.freedesktop.org/andrealmeid/gpu-timeout
Thanks!
Changelog:
v5:
- Change from app to task also in structs, commit message and docs
- Add a check for NULL or empty task name string
v4:
- Change from APP to TASK
- Add defines for event_string and pid_string length
v3:
- Make comm_string and pid_string empty when there's no app info
- Change "app that caused ..." to "app involved ..."
- Clarify that devcoredump have more information about what happened
v2:
- Rebased on top of drm/drm-next
- Added new patch for documentation
André Almeida (3):
drm: Create a task info option for wedge events
drm/doc: Add a section about "Task information" for the wedge API
drm/amdgpu: Make use of drm_wedge_task_info
Documentation/gpu/drm-uapi.rst | 17 +++++++++++++++++
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +++++++++++++++++--
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 +++++-
drivers/gpu/drm/drm_drv.c | 19 +++++++++++++++----
drivers/gpu/drm/i915/gt/intel_reset.c | 3 ++-
drivers/gpu/drm/xe/xe_device.c | 3 ++-
include/drm/drm_device.h | 8 ++++++++
include/drm/drm_drv.h | 3 ++-
8 files changed, 68 insertions(+), 10 deletions(-)
--
2.49.0
next reply other threads:[~2025-05-20 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 16:32 André Almeida [this message]
2025-05-20 16:32 ` [PATCH v5 1/3] drm: Create a task info option for wedge events André Almeida
2025-05-21 9:11 ` Raag Jadav
2025-05-21 15:17 ` André Almeida
2025-05-20 16:32 ` [PATCH v5 2/3] drm/doc: Add a section about "Task information" for the wedge API André Almeida
2025-05-20 16:32 ` [PATCH v5 3/3] drm/amdgpu: Make use of drm_wedge_task_info André Almeida
2025-05-20 17:11 ` ✓ CI.Patch_applied: success for drm: Create a tas info option for wedge events Patchwork
2025-05-20 17:11 ` ✗ CI.checkpatch: warning " Patchwork
2025-05-20 17:12 ` ✓ CI.KUnit: success " Patchwork
2025-05-20 17:23 ` ✓ CI.Build: " Patchwork
2025-05-20 17:25 ` ✓ CI.Hooks: " Patchwork
2025-05-20 17:27 ` ✗ CI.checksparse: warning " Patchwork
2025-05-20 17:48 ` ✓ Xe.CI.BAT: success " Patchwork
2025-05-21 1:18 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250520163243.328746-1-andrealmeid@igalia.com \
--to=andrealmeid@igalia.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=krzysztof.karas@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raag.jadav@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=xaver.hugl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox