Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: intel-xe@lists.freedesktop.org
Subject: [PATCH v4 03/21] drm/i915/dsb: Introduce intel_dsb_exec_time_us()
Date: Mon,  9 Jun 2025 17:10:28 +0300	[thread overview]
Message-ID: <20250609141046.6244-4-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20250609141046.6244-1-ville.syrjala@linux.intel.com>

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Pull the magic 20 usec DSB execution deadline into
intel_dsb_arm_exec_time_us(), and also add its counterapart
for the non-arming register write section. For the non-arming
part we'll just throw in a random 80 usec for now so the total
is 100usec. The total exec time will be needed by the upcoming
flip queue code.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsb.c | 26 ++++++++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_dsb.h |  1 +
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 8cbb5695c651..c8011f5e4076 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -686,14 +686,36 @@ static u32 dsb_error_int_en(struct intel_display *display)
 	return errors;
 }
 
+/*
+ * FIXME calibrate these sensibly, ideally compute based on
+ * the number of regisetrs to be written. But that requires
+ * measuring the actual DSB execution speed on each platform
+ * (and the speed also depends on CDCLK and memory clock)...
+ */
+static int intel_dsb_noarm_exec_time_us(void)
+{
+	return 80;
+}
+
+static int intel_dsb_arm_exec_time_us(void)
+{
+	return 20;
+}
+
+int intel_dsb_exec_time_us(void)
+{
+	return intel_dsb_noarm_exec_time_us() +
+		intel_dsb_arm_exec_time_us();
+}
+
 void intel_dsb_vblank_evade(struct intel_atomic_state *state,
 			    struct intel_dsb *dsb)
 {
 	struct intel_crtc *crtc = dsb->crtc;
 	const struct intel_crtc_state *crtc_state =
 		intel_pre_commit_crtc_state(state, crtc);
-	/* FIXME calibrate sensibly */
-	int latency = intel_usecs_to_scanlines(&crtc_state->hw.adjusted_mode, 20);
+	int latency = intel_usecs_to_scanlines(&crtc_state->hw.adjusted_mode,
+					       intel_dsb_arm_exec_time_us());
 	int start, end;
 
 	/*
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.h b/drivers/gpu/drm/i915/display/intel_dsb.h
index ab6489749866..6bcfb03f3415 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.h
+++ b/drivers/gpu/drm/i915/display/intel_dsb.h
@@ -35,6 +35,7 @@ struct intel_dsb *intel_dsb_prepare(struct intel_atomic_state *state,
 void intel_dsb_finish(struct intel_dsb *dsb);
 void intel_dsb_gosub_finish(struct intel_dsb *dsb);
 void intel_dsb_cleanup(struct intel_dsb *dsb);
+int intel_dsb_exec_time_us(void);
 void intel_dsb_reg_write(struct intel_dsb *dsb,
 			 i915_reg_t reg, u32 val);
 void intel_dsb_reg_write_indexed(struct intel_dsb *dsb,
-- 
2.49.0


  parent reply	other threads:[~2025-06-09 14:11 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09 14:10 [PATCH v4 00/21] drm/i915/flipq: Rough flip queue implementation Ville Syrjala
2025-06-09 14:10 ` [PATCH v4 01/21] drm/i915/dsb: Use intel_dsb_ins_align() in intel_dsb_align_tail() Ville Syrjala
2025-06-10 21:24   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 02/21] drm/i915/dsb: Provide intel_dsb_head() and intel_dsb_size() Ville Syrjala
2025-06-10 21:28   ` Shankar, Uma
2025-06-09 14:10 ` Ville Syrjala [this message]
2025-06-10 21:32   ` [PATCH v4 03/21] drm/i915/dsb: Introduce intel_dsb_exec_time_us() Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 04/21] drm/i915/dsb: Garbage collect the MMIO DEwake stuff Ville Syrjala
2025-06-10 21:41   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 05/21] drm/i915/dsb: Move the DSB_PMCTRL* reset out of intel_dsb_finish() Ville Syrjala
2025-06-10 21:50   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 06/21] drm/i915/dsb: Disable the GOSUB interrupt Ville Syrjala
2025-06-10 21:53   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 07/21] drm/i915/dmc: Limit PIPEDMC clock gating w/a to just ADL/DG2/MTL Ville Syrjala
2025-06-10 22:06   ` Shankar, Uma
2025-06-11 13:30     ` Ville Syrjälä
2025-06-12  5:12       ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 08/21] drm/i915/dmc: Parametrize MTL_PIPEDMC_GATING_DIS Ville Syrjala
2025-06-10 22:07   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 09/21] drm/i915: Set PKG_C_LATENCY.added_wake_time to 0 Ville Syrjala
2025-06-10 22:18   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 10/21] drm/i915: Try to program PKG_C_LATENCY more correctly Ville Syrjala
2025-06-09 14:10 ` [PATCH v4 11/21] drm/i915/dmc: Shuffle code around Ville Syrjala
2025-06-10 22:20   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 12/21] drm/i915/dmc: Reload PIPEDMC MMIO registers for pipe C/D on PTL+ Ville Syrjala
2025-06-10 23:24   ` Shankar, Uma
2025-06-11 14:25     ` Ville Syrjälä
2025-06-12  5:05       ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 13/21] drm/i915/dmc: Assert DMC is loaded harder Ville Syrjala
2025-06-09 14:10 ` [PATCH v4 14/21] drm/i915/dmc: Define flip queue related PIPEDMC registers Ville Syrjala
2025-06-19  7:29   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 15/21] drm/i915/flipq: Provide the nuts and bolts code for flip queue Ville Syrjala
2025-06-23 19:54   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 16/21] drm/i915/flipq: Implement flip queue based commit path Ville Syrjala
2025-06-23 19:58   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 17/21] drm/i915/flipq: Implement Wa_18034343758 Ville Syrjala
2025-06-23 20:05   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 18/21] drm/i915/flipq: Implement Wa_16018781658 for LNL-A0 Ville Syrjala
2025-06-23 20:08   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 19/21] drm/i915/flipq: Add intel_flipq_dump() Ville Syrjala
2025-06-23 20:09   ` Shankar, Uma
2025-06-09 14:10 ` [PATCH v4 20/21] drm/i915/flipq: Enable flipq by default for testing Ville Syrjala
2025-06-09 14:10 ` [PATCH v4 21/21] drm/i915/flipq: Disable PSR for extra flip queue coverage Ville Syrjala
2025-06-09 19:22 ` ✓ CI.Patch_applied: success for drm/i915/flipq: Rough flip queue implementation (rev6) Patchwork
2025-06-09 19:23 ` ✗ CI.checkpatch: warning " Patchwork
2025-06-09 19:24 ` ✓ CI.KUnit: success " Patchwork
2025-06-09 19:35 ` ✓ CI.Build: " Patchwork
2025-06-09 19:37 ` ✓ CI.Hooks: " Patchwork
2025-06-09 19:39 ` ✗ CI.checksparse: warning " Patchwork
2025-06-09 20:01 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-06-09 21:50 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609141046.6244-4-ville.syrjala@linux.intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox