From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com
Subject: [PATCH v3 0/6] Future-proof for multi-tile + multi-GT cases
Date: Mon, 30 Jun 2025 10:34:39 -0700 [thread overview]
Message-ID: <20250630173438.2342706-8-matthew.d.roper@intel.com> (raw)
Today all of our platforms fall into one of three cases:
* Single tile platforms with a single (primary) GT
* Single tile platforms with two GTs (primary + media)
* Two-tile platforms with a single GT (primary) in each
Our numbering of GTs has been a bit inconsistent between platforms
(e.g., GT1 is the media GT on some platforms, but the second tile's
primary GT on others). In the future we'll likely have platforms that
are both multi-tile and multi-GT, which will make the situation more
confusing. We could also wind up with more than just two types of GTs
at some point in the future.
Going forward we should standardize the way we assign uapi GT IDs to
internal GT structures. Let's declare that for userspace GT ID n,
GT[n]'s tile = n / (max gt per tile)
GT[n]'s slot within tile = n % (max gt per tile)
If we allow 'max gt per tile' to vary by platform, we can support any
possible future tile/GT combinations (even if new types of GTs show up)
without changing any behavior of our existing platforms.
v2:
- Rebase on top of the latest xe_pci test updates from Michal. Convert
the kunit test into a parameterized test that will run against each
PCI ID supported by the driver.
v3:
- Rebase again
- Add an additional patch at the end of the series to ensure
the GT query list is filled out properly.
Matt Roper (6):
drm/xe: Export xe_step_name for kunit tests
drm/xe: Track maximum GTs per tile on a per-platform basis
drm/xe/tests/pci: Ensure all platforms have a valid GT/tile count
drm/xe: Assign GT IDs properly on multi-tile + multi-GT platforms
drm/xe: Don't compare GT ID to GT count when determining valid GTs
drm/xe/xe_query: Use separate iterator while filling GT list
drivers/gpu/drm/xe/tests/xe_pci.c | 31 ++++++++++++
drivers/gpu/drm/xe/tests/xe_pci_test.c | 12 +++++
drivers/gpu/drm/xe/tests/xe_pci_test.h | 1 +
drivers/gpu/drm/xe/xe_device.h | 47 ++++++++----------
drivers/gpu/drm/xe/xe_device_types.h | 2 +
drivers/gpu/drm/xe/xe_eu_stall.c | 6 ++-
drivers/gpu/drm/xe/xe_exec_queue.c | 2 +-
drivers/gpu/drm/xe/xe_hw_engine.c | 3 +-
drivers/gpu/drm/xe/xe_mmio.c | 8 ---
drivers/gpu/drm/xe/xe_pci.c | 69 ++++++++------------------
drivers/gpu/drm/xe/xe_pci_types.h | 41 +++++++++++++++
drivers/gpu/drm/xe/xe_pmu.c | 4 +-
drivers/gpu/drm/xe/xe_query.c | 27 +++++-----
drivers/gpu/drm/xe/xe_step.c | 2 +
14 files changed, 154 insertions(+), 101 deletions(-)
--
2.49.0
next reply other threads:[~2025-06-30 17:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 17:34 Matt Roper [this message]
2025-06-30 17:34 ` [PATCH v3 1/6] drm/xe: Export xe_step_name for kunit tests Matt Roper
2025-06-30 23:54 ` Lucas De Marchi
2025-06-30 17:34 ` [PATCH v3 2/6] drm/xe: Track maximum GTs per tile on a per-platform basis Matt Roper
2025-07-01 5:05 ` Riana Tauro
2025-07-01 16:55 ` Matt Roper
2025-07-02 4:50 ` Riana Tauro
2025-06-30 17:34 ` [PATCH v3 3/6] drm/xe/tests/pci: Ensure all platforms have a valid GT/tile count Matt Roper
2025-06-30 17:34 ` [PATCH v3 4/6] drm/xe: Assign GT IDs properly on multi-tile + multi-GT platforms Matt Roper
2025-06-30 22:08 ` Cavitt, Jonathan
2025-06-30 17:34 ` [PATCH v3 5/6] drm/xe: Don't compare GT ID to GT count when determining valid GTs Matt Roper
2025-06-30 22:08 ` Cavitt, Jonathan
2025-06-30 17:34 ` [PATCH v3 6/6] drm/xe/xe_query: Use separate iterator while filling GT list Matt Roper
2025-06-30 22:08 ` Cavitt, Jonathan
2025-06-30 22:14 ` Matt Roper
2025-06-30 22:15 ` [PATCH v3.1 " Matt Roper
2025-07-01 14:05 ` Cavitt, Jonathan
2025-07-01 7:31 ` ✗ CI.checkpatch: warning for Future-proof for multi-tile + multi-GT cases (rev4) Patchwork
2025-07-01 7:32 ` ✓ CI.KUnit: success " Patchwork
2025-07-01 8:10 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-07-01 16:18 ` ✗ CI.checkpatch: warning for Future-proof for multi-tile + multi-GT cases (rev5) Patchwork
2025-07-01 16:19 ` ✓ CI.KUnit: success " Patchwork
2025-07-02 22:41 ` ✗ Xe.CI.Full: failure for Future-proof for multi-tile + multi-GT cases (rev4) Patchwork
2025-07-02 23:14 ` Matt Roper
2025-07-02 23:22 ` Matt Roper
2025-07-03 10:23 ` ✗ Xe.CI.Full: failure for Future-proof for multi-tile + multi-GT cases (rev5) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250630173438.2342706-8-matthew.d.roper@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox