Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: matthew.d.roper@intel.com, Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: [PATCH v3 1/6] drm/xe: Export xe_step_name for kunit tests
Date: Mon, 30 Jun 2025 10:34:40 -0700	[thread overview]
Message-ID: <20250630173438.2342706-9-matthew.d.roper@intel.com> (raw)
In-Reply-To: <20250630173438.2342706-8-matthew.d.roper@intel.com>

xe_step_name() is used by xe_assert(), so adding assertions to functions
like xe_device_get_gt() will result in

  ERROR: modpost: "xe_step_name" [drivers/gpu/drm/xe/tests/xe_test.ko] undefined!

while building the kunit tests.  Export xe_step_name to avoid these
build failures when adding assertions.

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_step.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_step.c b/drivers/gpu/drm/xe/xe_step.c
index c77b5c317fa0..10e88f2c9615 100644
--- a/drivers/gpu/drm/xe/xe_step.c
+++ b/drivers/gpu/drm/xe/xe_step.c
@@ -5,6 +5,7 @@
 
 #include "xe_step.h"
 
+#include <kunit/visibility.h>
 #include <linux/bitfield.h>
 
 #include "xe_device.h"
@@ -255,3 +256,4 @@ const char *xe_step_name(enum xe_step step)
 		return "**";
 	}
 }
+EXPORT_SYMBOL_IF_KUNIT(xe_step_name);
-- 
2.49.0


  reply	other threads:[~2025-06-30 17:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 17:34 [PATCH v3 0/6] Future-proof for multi-tile + multi-GT cases Matt Roper
2025-06-30 17:34 ` Matt Roper [this message]
2025-06-30 23:54   ` [PATCH v3 1/6] drm/xe: Export xe_step_name for kunit tests Lucas De Marchi
2025-06-30 17:34 ` [PATCH v3 2/6] drm/xe: Track maximum GTs per tile on a per-platform basis Matt Roper
2025-07-01  5:05   ` Riana Tauro
2025-07-01 16:55     ` Matt Roper
2025-07-02  4:50       ` Riana Tauro
2025-06-30 17:34 ` [PATCH v3 3/6] drm/xe/tests/pci: Ensure all platforms have a valid GT/tile count Matt Roper
2025-06-30 17:34 ` [PATCH v3 4/6] drm/xe: Assign GT IDs properly on multi-tile + multi-GT platforms Matt Roper
2025-06-30 22:08   ` Cavitt, Jonathan
2025-06-30 17:34 ` [PATCH v3 5/6] drm/xe: Don't compare GT ID to GT count when determining valid GTs Matt Roper
2025-06-30 22:08   ` Cavitt, Jonathan
2025-06-30 17:34 ` [PATCH v3 6/6] drm/xe/xe_query: Use separate iterator while filling GT list Matt Roper
2025-06-30 22:08   ` Cavitt, Jonathan
2025-06-30 22:14     ` Matt Roper
2025-06-30 22:15   ` [PATCH v3.1 " Matt Roper
2025-07-01 14:05     ` Cavitt, Jonathan
2025-07-01  7:31 ` ✗ CI.checkpatch: warning for Future-proof for multi-tile + multi-GT cases (rev4) Patchwork
2025-07-01  7:32 ` ✓ CI.KUnit: success " Patchwork
2025-07-01  8:10 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-07-01 16:18 ` ✗ CI.checkpatch: warning for Future-proof for multi-tile + multi-GT cases (rev5) Patchwork
2025-07-01 16:19 ` ✓ CI.KUnit: success " Patchwork
2025-07-02 22:41 ` ✗ Xe.CI.Full: failure for Future-proof for multi-tile + multi-GT cases (rev4) Patchwork
2025-07-02 23:14   ` Matt Roper
2025-07-02 23:22     ` Matt Roper
2025-07-03 10:23 ` ✗ Xe.CI.Full: failure for Future-proof for multi-tile + multi-GT cases (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250630173438.2342706-9-matthew.d.roper@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.wajdeczko@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox