Re: [PATCH] drm/xe/xe_pmu: Validate gt in event supported

[Matt Roper <matthew.d.roper@intel.com>]

On Mon, Jun 30, 2025 at 05:28:53PM -0500, Lucas De Marchi wrote:
> On Mon, Jun 30, 2025 at 03:07:41PM +0530, Riana Tauro wrote:
> > Validate gt instead of checking gt_id is lesser
> > than max gts per tile
> 
> I prefer the series from Matt Roper that is refactoring this part well.

I think we want this change regardless.  My series is about refactoring
to future-proof the behavior in case we wind up with multi-tile+multi-GT
platforms in the future.  However Riana's patch here is fixing a real
bug in the code that exists for existing platforms like PVC (i.e., the
code currently lets "GT1" through as valid even on single-tile variants
of PVC).

So we should either land this patch first (which will remove a hunk from
one of my patches), or make this as a separate change on top of my
series.  In the latest version of my series (v4) I included a patch
identical to this one as patch #1 since I didn't notice that this patch
was exactly the same thing; if this one lands, then we can drop the
first one from v4 of my series.


Matt

> 
> Lucas De Marchi

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation