Re: drm/xe/xe_pmu: Validate gt in event supported

[Riana Tauro <riana.tauro@intel.com>]

Hi Karthik

On 6/30/2025 9:03 PM, Poosa, Karthik wrote:
> 
> On 30-06-2025 15:07, Riana Tauro wrote:
>> Validate gt instead of checking gt_id is lesser
>> than max gts per tile
>>
>> Signed-off-by: Riana Tauro<riana.tauro@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_pmu.c | 7 +++++--
>>   1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_pmu.c b/drivers/gpu/drm/xe/xe_pmu.c
>> index 69df0e3520a5..cab51d826345 100644
>> --- a/drivers/gpu/drm/xe/xe_pmu.c
>> +++ b/drivers/gpu/drm/xe/xe_pmu.c
>> @@ -157,10 +157,13 @@ static bool event_gt_forcewake(struct perf_event 
>> *event)
>>       return true;
>>   }
>> -static bool event_supported(struct xe_pmu *pmu, unsigned int gt,
>> +static bool event_supported(struct xe_pmu *pmu, unsigned int gt_id,
>>                   unsigned int id)
>>   {
>> -    if (gt >= XE_MAX_GT_PER_TILE)
>> +    struct xe_device *xe = container_of(pmu, typeof(*xe), pmu);
>> +    struct xe_gt *gt = xe_device_get_gt(xe, gt_id);
> 
> Looks like xe_device_get_gt() would return primary_gt handle, instead of 
> NULL, if gt_id > XE_MAX_GT_PER_TILE. gt would be always valid then !

Yes it returns the gt struct for the id. If its NULL then the gt_id is 
invalid and event is not supported.

Thanks
Riana>
>> +
>> +    if (!gt)
>>           return false;
>>       return id < sizeof(pmu->supported_events) * BITS_PER_BYTE &&