Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>,
	Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
	Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Subject: [PATCH 4/4] drm/xe/psmi: Add Wa_16023683509
Date: Wed, 16 Jul 2025 13:55:47 -0700	[thread overview]
Message-ID: <20250716-psmi-v1-4-674c13d7028e@intel.com> (raw)
In-Reply-To: <20250716-psmi-v1-0-674c13d7028e@intel.com>

From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

This WA ensures GuC will restore the media MCFG registers at C6
exit.

Cc: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_guc.c        | 3 +++
 drivers/gpu/drm/xe/xe_guc_fwif.h   | 1 +
 drivers/gpu/drm/xe/xe_wa_oob.rules | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index 4d11c3a66ad38..04e2e86e4e496 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -218,6 +218,9 @@ static u32 guc_ctl_wa_flags(struct xe_guc *guc)
 	if (XE_WA(gt, 14018913170))
 		flags |= GUC_WA_ENABLE_TSC_CHECK_ON_RC6;
 
+	if (XE_WA(gt, 16023683509))
+		flags |= GUC_WA_SAVE_RESTORE_MCFG_REG_AT_MC6;
+
 	return flags;
 }
 
diff --git a/drivers/gpu/drm/xe/xe_guc_fwif.h b/drivers/gpu/drm/xe/xe_guc_fwif.h
index 2a5256c24b9d8..e69938ea27569 100644
--- a/drivers/gpu/drm/xe/xe_guc_fwif.h
+++ b/drivers/gpu/drm/xe/xe_guc_fwif.h
@@ -103,6 +103,7 @@ struct guc_update_exec_queue_policy {
 #define   GUC_WA_RENDER_RST_RC6_EXIT	BIT(19)
 #define   GUC_WA_RCS_REGS_IN_CCS_REGS_LIST	BIT(21)
 #define   GUC_WA_ENABLE_TSC_CHECK_ON_RC6	BIT(22)
+#define   GUC_WA_SAVE_RESTORE_MCFG_REG_AT_MC6 	BIT(25)
 
 #define GUC_CTL_FEATURE			2
 #define   GUC_CTL_ENABLE_SLPC		BIT(2)
diff --git a/drivers/gpu/drm/xe/xe_wa_oob.rules b/drivers/gpu/drm/xe/xe_wa_oob.rules
index 91e717bba455f..b7083f8a728c6 100644
--- a/drivers/gpu/drm/xe/xe_wa_oob.rules
+++ b/drivers/gpu/drm/xe/xe_wa_oob.rules
@@ -70,6 +70,8 @@ no_media_l3	MEDIA_VERSION(3000)
 		MEDIA_VERSION(2000)
 		MEDIA_VERSION(3000)
 		MEDIA_VERSION(3002)
+16023683509	MEDIA_VERSION(2000)
+		MEDIA_VERSION(3000), GRAPHICS_STEP(A0, B0)
 
 # SoC workaround - currently applies to all platforms with the following
 # primary GT GMDID

-- 
2.49.0


  parent reply	other threads:[~2025-07-16 20:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16 20:55 [PATCH 0/4] drm/xe: Add psmi support Lucas De Marchi
2025-07-16 20:55 ` [PATCH 1/4] drm/xe/psmi: Add setting of PSMI feature flag Lucas De Marchi
2025-08-21 17:24   ` Matt Atwood
2025-07-16 20:55 ` [PATCH 2/4] drm/xe/psmi: Add debugfs interface for allocation of PSMI capture buffers Lucas De Marchi
2025-07-16 20:55 ` [PATCH 3/4] drm/xe/psmi: Enable GuC Wa_14020001231 Lucas De Marchi
2025-07-16 20:55 ` Lucas De Marchi [this message]
2025-07-16 21:05 ` ✗ CI.checkpatch: warning for drm/xe: Add psmi support Patchwork
2025-07-16 21:07 ` ✓ CI.KUnit: success " Patchwork
2025-07-16 21:58 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-17 19:19 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-17 19:47 ` [PATCH 0/4] " Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716-psmi-v1-4-674c13d7028e@intel.com \
    --to=lucas.demarchi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sai.teja.pottumuttu@intel.com \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox